Skip to content

Fixing timeout argument on 'New browser' #2064 #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaltat merged 1 commit into from
Jun 14, 2022
Merged

Fixing timeout argument on 'New browser' #2064 #2108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Browser/keywords/playwright_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,8 +492,7 @@ def new_browser(
"""
params = locals_to_params(locals())
params = convert_typed_dict(self.new_context.__annotations__, params)
if timeout:
params["timeout"] = self.convert_timeout(timeout)
params["timeout"] = self.convert_timeout(timeout)
params["slowMo"] = self.convert_timeout(slowMo)

browser_path = self.library.external_browser_executable.get(browser)
Expand Down
14 changes: 14 additions & 0 deletions atest/test/01_Browser_Management/open_browser.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
*** Settings ***
Resource imports.resource

Test Teardown Close Browser ALL

*** Test Cases ***
Open Browser With Timeout Of Zero Seconds
New Browser browser=${BROWSER} headless=${HEADLESS} timeout=0 seconds
New Browser browser=${BROWSER} headless=${HEADLESS} timeout=0 second
New Browser browser=${BROWSER} headless=${HEADLESS} timeout=0 s
New Browser browser=${BROWSER} headless=${HEADLESS} timeout=0s

Open Browser With Default Timeout
New Browser browser=${BROWSER} headless=${HEADLESS}
12 changes: 12 additions & 0 deletions utest/test_python_usage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import pytest
from assertionengine import AssertionOperator

from Browser import SupportedBrowsers


@pytest.fixture()
def application_server():
Expand Down Expand Up @@ -49,6 +51,16 @@ def test_new_browser_and_close(browser):
browser.close_browser()


def test_new_browser_with_timeout_of_zero_seconds(browser):
browser.new_browser(browser=SupportedBrowsers.chromium, headless=True, timeout="0")
browser.close_browser("ALL")


def test_new_browser_with_default_timeout(browser):
browser.new_browser(browser=SupportedBrowsers.chromium, headless=True)
browser.close_browser("ALL")


def test_playwright_exit_handler(atexit_register):
import Browser

Expand Down