Fixes for addWorklogAndAutoAdjustRemainingEstimate #16

Merged
merged 3 commits into from Mar 22, 2012

Conversation

Projects
None yet
2 participants
@justfalter
Contributor

justfalter commented Mar 22, 2012

When I went to go use addWorklogAndAutoAdjustRemainingEstimate, I found that it did not work for a couple reasons:

  1. addWorklogAndAutoAdjustRemainingEstimate wasn't being called properly
  2. JIRA::Worklog's wouldn't parse startDate because it was using :to_date instead of :to_iso_date.

This pull request fixes both of these issues, and I'm now able to log time against my jira project.

@ferrous26

This comment has been minimized.

Show comment Hide comment
@ferrous26

ferrous26 Mar 22, 2012

Could you also change this to @return [Time] since it now returns a Time object?

Could you also change this to @return [Time] since it now returns a Time object?

This comment has been minimized.

Show comment Hide comment
@justfalter

justfalter Mar 22, 2012

Owner

Just pushed some more code your way to include this change. Thanks!

Owner

justfalter replied Mar 22, 2012

Just pushed some more code your way to include this change. Thanks!

@ferrous26

This comment has been minimized.

Show comment Hide comment
@ferrous26

ferrous26 Mar 22, 2012

Member

Looks good, I'll merge this and make a release tonight.

Member

ferrous26 commented Mar 22, 2012

Looks good, I'll merge this and make a release tonight.

@ferrous26

This comment has been minimized.

Show comment Hide comment
@ferrous26

ferrous26 Mar 22, 2012

Member

Thank you! :shipit:

Member

ferrous26 commented Mar 22, 2012

Thank you! :shipit:

ferrous26 added a commit that referenced this pull request Mar 22, 2012

Merge pull request #16 from justfalter/worklogs
Fixes for addWorklogAndAutoAdjustRemainingEstimate

@ferrous26 ferrous26 merged commit d5991d0 into Marketcircle:master Mar 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment