Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix-2.0.x] dual_Z endstop and probing, Probing failed! [fix included] #12727

Closed
TAz00 opened this issue Dec 25, 2018 · 3 comments

Comments

Projects
None yet
5 participants
@TAz00
Copy link

commented Dec 25, 2018

Description

I was having the same problem as this guy : #11134
But I have dual_z endstops and use YMax pin for probe.

I'm using 1.1.9, but I've checked the code for bugfix 2.0.x and the "bug" is there aswell.

Steps to Reproduce

#11134

Suggested Fix

Expand the previous commit 485d50e to also cover DUAL_Z_ENDSTOPS

MarlinFirmware/Marlin/blob/bugfix-2.0.x/Marlin/src/module/endstops.cpp

    #if ENABLED(Z_DUAL_ENDSTOPS)
      #if ENABLED(Z_MIN_PROBE_ENDSTOP)  
        if (!z_probe_enabled) PROCESS_DUAL_ENDSTOP(Z, Z2, MIN);;
      #else
        PROCESS_DUAL_ENDSTOP(Z, Z2, MIN);
      #endif
    #else
      #if ENABLED(Z_MIN_PROBE_USES_Z_MIN_ENDSTOP_PIN)
        if (z_probe_enabled) PROCESS_ENDSTOP(Z, MIN);
      #elif ENABLED(Z_MIN_PROBE_ENDSTOP)
        if (!z_probe_enabled) PROCESS_ENDSTOP(Z, MIN);
      #else
        PROCESS_ENDSTOP(Z, MIN);
      #endif
    #endif

@TAz00 TAz00 changed the title bugfix-2.0.x dual_Z endstop and probing [bugfix-2.0.x] dual_Z endstop and probing, Probing failed! [fix included] Dec 25, 2018

@phenomenon777

This comment has been minimized.

Copy link

commented Dec 27, 2018

i also use the1.19version,the photoelectric limit switch,can not be used,click to start printing ,the machine will rise to max and then hit

@boelle

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

@TAz00 submit PR to bugfix 2.0

@kulfuerst

This comment has been minimized.

Copy link

commented May 23, 2019

The code, as it is standing here, only works in Marlin 1.1.9. To make it work in Marlin2 slight changes have to be made.

    #elif ENABLED(Z_DUAL_ENDSTOPS)
      #if USES_Z_MIN_PROBE_ENDSTOP  
        if (!z_probe_enabled) PROCESS_DUAL_ENDSTOP(Z, Z2, MIN);;
      #else
        PROCESS_DUAL_ENDSTOP(Z, Z2, MIN);
      #endif
    #else
      #if ENABLED(Z_MIN_PROBE_USES_Z_MIN_ENDSTOP_PIN)
        if (z_probe_enabled) PROCESS_ENDSTOP(Z, MIN);
      #elif USES_Z_MIN_PROBE_ENDSTOP)
        if (!z_probe_enabled) PROCESS_ENDSTOP(Z, MIN);
      #else
        PROCESS_ENDSTOP(Z, MIN);
      #endif
    #endif
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.