New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1.x] Fix Ender 4 compilation, add more AVRs to Makefile #10271

Merged
merged 2 commits into from Apr 1, 2018

Conversation

Projects
None yet
2 participants
@D-side
Copy link
Contributor

D-side commented Apr 1, 2018

Description

I tried to build Creality Ender-4's configuration for my Creality CR-8, which turned out to have the exact same mainboard, And I failed. After getting my head around Marlin's structure for a while I found out that the board ID referenced in configuration does not exist in Makefile or boards.h

I picked an unlisted board ID, 49 and added it in.

Benefits

This makes configuration for Creality Ender-4's board, actually compilable.

Related Issues

  • #9256 is the original discussion on the Ender 4 board

I'm not knowledgeable in Marlin and 3D printing electronics. Let me know if I should make any changes 馃槂

NB: while CR-8 does feature the same board, the configuration is different. I'll provide that separately once I'm done with it.

@D-side

This comment has been minimized.

Copy link
Contributor Author

D-side commented Apr 1, 2018

The only thing I don't have working at this point is hotend heater. It appears it's sitting on a different pin than the one specified.

UPD: except my multimeter says it's there...

@thinkyhead
Copy link
Member

thinkyhead left a comment

A change is needed.

@@ -76,6 +76,7 @@
#define BOARD_BQ_ZUM_MEGA_3D 503 // bq ZUM Mega 3D
#define BOARD_MAKEBOARD_MINI 431 // MakeBoard Mini v2.1.2 is a control board sold by MicroMake
#define BOARD_TRIGORILLA 343 // TriGorilla Anycubic version 1.3 based on RAMPS EFB
#define BOARD_RAMPS_ENDER_4 49 // Creality: Ender-4, CR-8

This comment has been minimized.

@thinkyhead

thinkyhead Apr 1, 2018

Member

This conflicts with BOARD_SAINSMART_2IN1. We'll have to pick a different ID. But, isn't the Ender 4 board very similar to the BOARD_MELZI_CREALITY?

This comment has been minimized.

@D-side

D-side Apr 1, 2018

Author Contributor

Oops. Not sure how I didn't spot that.

Is there any particular convention for choosing these IDs?

This comment has been minimized.

@D-side

D-side Apr 1, 2018

Author Contributor

But, isn't the Ender 4 board just the same as BOARD_MELZI_CREALITY?

Nope. It's mostly RAMPS/Mega2560-equivalent, but there is one oddity that may actually be related to the issue you spotted. I'm diagnosing it now.

@thinkyhead thinkyhead force-pushed the D-side:ender-4-board-id branch from dabcaa0 to d0e8151 Apr 1, 2018

@thinkyhead

This comment has been minimized.

Copy link
Member

thinkyhead commented Apr 1, 2018

I've changed the ID to 243 (similar to EFB). If Endstop, Fan, Fan (EFF) is more appropriate, we can change it to 245.

@D-side D-side force-pushed the D-side:ender-4-board-id branch from d0e8151 to 41193cd Apr 1, 2018

@thinkyhead thinkyhead force-pushed the D-side:ender-4-board-id branch from 41193cd to bf46d4d Apr 1, 2018

@thinkyhead

This comment has been minimized.

Copy link
Member

thinkyhead commented Apr 1, 2018

鈥lso seemed like a good time to add remaining boards to Makefile.

@D-side

This comment has been minimized.

Copy link
Contributor Author

D-side commented Apr 1, 2018

@thinkyhead alright, 243 it is. So I've been using pin configuration of a different board. Not my finest piece of work 馃檭 Thankfully, the printer survived the torture.
I applied one more change to make Ender-4's configuration compilable.

@thinkyhead

This comment has been minimized.

Copy link
Member

thinkyhead commented Apr 1, 2018

Oh yes, that's important too!

D-side and others added some commits Apr 1, 2018

Fix Ender 4 / CR-8 compilation
- Assign 243 (like EFB) as Ender-4/CR-8 board ID
- Add to `Makefile`
- Add to `pins.h`

@thinkyhead thinkyhead force-pushed the D-side:ender-4-board-id branch from 664cfc0 to 6444ef0 Apr 1, 2018

@thinkyhead thinkyhead changed the title [1.1.x] Assign an ID to the Ender-4/CR-8 board [1.1.x] Fix Ender 4 compilation, add more AVRs to Makefile Apr 1, 2018

@thinkyhead thinkyhead merged commit 2dafc10 into MarlinFirmware:bugfix-1.1.x Apr 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@D-side D-side deleted the D-side:ender-4-board-id branch Apr 1, 2018

@D-side

This comment has been minimized.

Copy link
Contributor Author

D-side commented Apr 1, 2018

Thanks!

I'll follow up soon with example configuration for CR-8. Now that it actually compiles with no changes other than configuraiton.

@thinkyhead

This comment has been minimized.

Copy link
Member

thinkyhead commented Apr 2, 2018

Looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment