Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializes the D-axis on Hangprinter and counts advance_dividend and… #12181

Conversation

tobbelobb
Copy link

@tobbelobb tobbelobb commented Oct 21, 2018

… delta_offsets for D-axis

Description

Hangprinter users reported their D-axes weren't moving.

I tracked down the issue to E1 pins not being initialized, and that advance_dividend and delta_error arrays hadn't been prepared for Hangprinter usage (D_AXIS not used).

Benefits

Hangprinter+Marlin users gains control over their D motors.

@thinkyhead thinkyhead force-pushed the bugfix-1.1.x_hangprinter_patch_0 branch from b3cb3ba to 8a4b92e Compare Oct 22, 2018
@thinkyhead
Copy link
Member

thinkyhead commented Oct 22, 2018

When GitHub returns back to normal this will, I hope, automagically be rebased, and then I'll merge it. I'm not trusting GitHub until all the bizarre errors and glitches seen today are solved.

@tobbelobb
Copy link
Author

tobbelobb commented Oct 22, 2018

When GitHub returns back to normal this will, I hope, automagically be rebased, and then I'll merge it. I'm not trusting GitHub until all the bizarre errors and glitches seen today are solved.

@thinkyhead You're right. This does look bizarre. I have messages that "all checks passed" and "the travis cl build failed" showing simultaneously. And your comment shows only in my email inbox, not in this thread (Github's web interface). I did fetch and rebase right before creating the PR, so no further rebase should be needed.

Hope it gets sorted out. The patch is really a small one. I could just send you a patch file via email if Github keeps having glitches.

@thinkyhead thinkyhead merged commit cbc0a0a into MarlinFirmware:bugfix-1.1.x Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants