Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stepper use before init. Add Ultimaker2+ Extended clone config #13284

Merged
merged 3 commits into from Mar 2, 2019

Conversation

Projects
None yet
4 participants
@svpcom
Copy link

svpcom commented Mar 2, 2019

  1. Fix stepper use before init. EEPROM read function try to control streppers before init (this results in extruder move during system boot).
  2. Add support of hotend fan for Ultimainboard V2.0. It located on non-standard pin which is unaccessable from arduino lib.
  3. Add sample configs for Ultimaker2+ Extended clone from AliExpress
@p3p

This comment has been minimized.

Copy link
Member

p3p commented Mar 2, 2019

Marlin has a method for accessing non Arduino pins, PJ6 is mapped as pin 77 .. at least that's what is in the fastio_1280.h file.

@svpcom

This comment has been minimized.

Copy link
Author

svpcom commented Mar 2, 2019

https://www.arduino.cc/en/Hacking/PinMapping2560
PJ6 is not mapped on atmega2560

@p3p

This comment has been minimized.

Copy link
Member

p3p commented Mar 2, 2019

Marlin uses its own FastIO macros, not the Arduino functions, this file (src/HAL/HAL_AVR/fastio_1280.h) maps the pin identifiers to the ports, and it looks like 77 is mapped to PJ6.

@svpcom

This comment has been minimized.

Copy link
Author

svpcom commented Mar 2, 2019

PINJ6 is not defined anywhere in sources:

/**
 * Pin mapping for the 1280 and 2560
 *
 *   Hardware Pin  : ... 69 ...
 *   Port          : ... J6 ...
 *   Logical Pin   : ... xx ...
 */
$ git grep PINJ6 upstream/bugfix-2.0.x
upstream/bugfix-2.0.x:src/HAL/HAL_AVR/fastio_1280.h:#define DIO77_PIN   PINJ6
upstream/bugfix-2.0.x:src/HAL/HAL_AVR/fastio_1280.h:#define PJ6_PIN     PINJ6
@p3p

This comment has been minimized.

Copy link
Member

p3p commented Mar 2, 2019

It's from the AVR headers. Just using pin 77 in the pins file should work.

@thinkyhead thinkyhead force-pushed the svpcom:bugfix-2.0.x-svpcom-pullrequest branch from d779399 to d1513b6 Mar 2, 2019

@thinkyhead thinkyhead merged commit 71773b1 into MarlinFirmware:bugfix-2.0.x Mar 2, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@thinkyhead thinkyhead changed the title [2.0.x] Fix stepper use before init. Add support for Ultimaker2+ Extended Fix stepper use before init. Add Ultimaker2+ Extended clone config Mar 2, 2019

@svpcom svpcom deleted the svpcom:bugfix-2.0.x-svpcom-pullrequest branch Mar 3, 2019

@dot-bob

This comment has been minimized.

Copy link
Contributor

dot-bob commented Mar 3, 2019

This commit has breaks stepper initialization if your printer uses HAS_MOTOR_CURRENT_PWM. Currents do not get updated upon boot.

@svpcom

This comment has been minimized.

Copy link
Author

svpcom commented Mar 3, 2019

@dot-bob Why?
Stepper::init -> digipot_init -> digipot_current

@dot-bob

This comment has been minimized.

Copy link
Contributor

dot-bob commented Mar 3, 2019

I just submitted a pull request that fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.