Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch on top of the earlier PR #3189 by @WPBack. This PR adds onto the original by making the Autotune items into edit items so a target temperature can be selected. When the click-wheel is pressed, the selected value will be used as the "
S
" parameter toM303
.Additional changes were needed.
M303
they default to150
. (Perhaps they would all be better to default toEXTRUDE_MINTEMP
, but that's another topic.)const
array to store the heater max temps so that these values can be picked up by the macro. (This is necessary because the pre-processor cannot recurse. I.e., you cannot compose a macro name from substitution parts [like thee
here inHEATER_## e ##_MAXTEMP
] and then get the value of that macro – it's just too "meta"). Aconst
array gets around this limitation.U
parameter is now documented in the comment togcode_M303
and takes any non-zero value as "true".enqueue_and_echo_command_now
was added as a way to always enqueue a command now, only returning to the caller once the command is enqueued, whereas the functionenqueue_and_echo_command
may return immediately without success. The new function was applied to a point incardreader.cpp
whereenqueue_and_echo_command
might (extremely rarely) cause a failure to enqueue theM23
command.COPY_AND_SCALE
internal macro to the more appropriate_PIDTEMP_FUNCTIONS
since it now defines more menu functions.