New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1] Add support for PICA shield #7454

Closed
wants to merge 10 commits into
base: bugfix-1.1.x
from

Conversation

Projects
None yet
3 participants
@Squid116

Squid116 commented Aug 7, 2017

This is a redo of:
#5766

I have cleaned up and included only files relating to the PICA shield, including the suggested improvements about splitting up the pins files.

mjrice and others added some commits Feb 2, 2017

added support for PICA shield
added board id and pins definitions for the pica board.

@thinkyhead thinkyhead changed the title from Add support for PICA shield to [1.1] Add support for PICA shield Nov 11, 2017

#define encrot0 0
#define encrot1 2
#define encrot2 3
#define encrot3 1

This comment has been minimized.

@thinkyhead

thinkyhead Nov 11, 2017

Member

These setting are no longer needed in current version of Marlin.

#define BLEN_C 2
#define BLEN_B 1
#define BLEN_A 0

This comment has been minimized.

@thinkyhead

thinkyhead Nov 11, 2017

Member

These setting are no longer needed in current version of Marlin.

#define encrot0 0
#define encrot1 2
#define encrot2 3
#define encrot3 1

This comment has been minimized.

@thinkyhead

thinkyhead Nov 11, 2017

Member

These setting are no longer needed in current version of Marlin.

#define BLEN_C 2
#define BLEN_B 1
#define BLEN_A 0

This comment has been minimized.

@thinkyhead

thinkyhead Nov 11, 2017

Member

These setting are no longer needed in current version of Marlin.

#define KILL_PIN -1
#define SSR_PIN 6

This comment has been minimized.

@thinkyhead

thinkyhead Nov 11, 2017

Member

SSR_PIN is not known or used by Marlin.

#error "Oops! Make sure you have 'Arduino Mega' selected from the 'Tools -> Boards' menu."
#endif
#define KNOWN_BOARD 1

This comment has been minimized.

@thinkyhead

thinkyhead Nov 11, 2017

Member

KNOWN_BOARD is not needed for current Marlin.

#error "Oops! Make sure you have 'Arduino Mega' selected from the 'Tools -> Boards' menu."
#endif
#define KNOWN_BOARD 1

This comment has been minimized.

@thinkyhead

thinkyhead Nov 11, 2017

Member

KNOWN_BOARD is not needed for the current Marlin.

#define SDPOWER -1
#define LED_PIN -1
#define PS_ON_PIN -1
#define KILL_PIN -1

This comment has been minimized.

@thinkyhead

thinkyhead Nov 11, 2017

Member

These 4 unused pins can be left out entirely.

#define SDPOWER -1
#define LED_PIN -1
#define PS_ON_PIN -1
#define KILL_PIN -1

This comment has been minimized.

@thinkyhead

thinkyhead Nov 11, 2017

Member

These 4 unused pins can be left out entirely.

#define KILL_PIN -1
#define SSR_PIN 6

This comment has been minimized.

@thinkyhead

thinkyhead Nov 11, 2017

Member

SSR_PIN is not known or used by Marlin.

#define TEMP_0_PIN 9 // ANALOG NUMBERING
#define TEMP_1_PIN 10
#define TEMP_BED_PIN 10

This comment has been minimized.

@thinkyhead

thinkyhead Nov 11, 2017

Member

See how pins_RAMPS.h handles auto-assigning the temp sensor and heater pins according to configuration settings. It automatically determines when the arrangement should be EEB, EFB, EEF, EFF, etc.

This comment has been minimized.

@Squid116

Squid116 Nov 14, 2017

PICA has optional support for an SSR output for the heated bed. (hence $ssr_pin above) what letter would you recommend we use in this format when the heated bed is on the SSR?
It would be EFB or EFFB - but it would be better to specify if the B (bed) was ussing an SSR (S? R?)

This comment has been minimized.

@thinkyhead

thinkyhead Feb 10, 2018

Member

When I get around to merging it, I'll let you know. At the moment trying to clear old issues.

Squid116 added some commits Dec 7, 2017

@thinkyhead

This comment has been minimized.

Member

thinkyhead commented Oct 24, 2018

At this point Marlin 1.1.x is end-of-life, so this PR will need to be re-done starting from bugfix-2.0.x and targeting that branch. Sorry for the inconvenience!

@thinkyhead thinkyhead closed this Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment