Skip to content
Commits on Jul 10, 2012
  1. @fabpot

    merged branch jfsimon/issue-4752 (PR #4832)

    fabpot committed
    Commits
    -------
    
    50cf928 [Console] Removed pointless constant.
    14bd5ba [Console] 'formatBlock' helper now escape messages.
    aaf4950 [Console] Implemented '<' escaping.
    8cf82b7 [Console] Added '<' escaping tests.
    
    Discussion
    ----------
    
    Issue 4752
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #4752
    
    This PR adds possibility to escape `<` chars with `\` to avoid formatting mess.
    In addition, `FormatterHelper::formatBlock()` method auto-escapes messages.
  2. @fabpot
  3. @fabpot
  4. @fabpot

    merged branch bschussek/issue3387 (PR #4835)

    fabpot committed
    Commits
    -------
    
    5b057f8 [Form] Fixed DateType to use "format" for creating the year and day choices
    
    Discussion
    ----------
    
    [Form] Fixed DateType to use "format" for creating the year and day choices
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #3490
    Todo: -
  5. @fabpot
  6. @webmozart
  7. @jfsimon
  8. @fabpot

    [Console] replaced var_export with json_encode for default values whe…

    fabpot committed
    …n exported as text/xml to make them more readable (closes #4193)
  9. @fabpot

    merged branch ChrisTickner/formbuilder_remove_bug_fix (PR #4826)

    fabpot committed
    Commits
    -------
    
    f71e2a8 [Form] FormBuilder Bug Fix: remove() was not properly removing children
    
    Discussion
    ----------
    
    [Form] FormBuilder Bug Fix: remove() was not properly removing children
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #4803
    License of the code: MIT
    
    FormBuilder initially sets unresolved children as NULL, until resolved.
     If FormBuilder::remove() is called before that child is resolved, the
    if statement turns false, because isset(null) is false, when it should
    be true.  Instead, we should check to see if the key exists, and if so,
    process and unset it.
    
    Closes #4803
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-07-10T07:41:55Z
    
    Can you please add a test covering this case?
    
    ---------------------------------------------------------------------------
    
    by ChrisTickner at 2012-07-10T09:43:07Z
    
    Sure, added a test case.  It fails before the patch and passes after.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-07-10T09:47:06Z
    
    Thanks. Can you please add a comment to the test with the URL of this PR? Also, please squash your commits into one when your done.
    
    ---------------------------------------------------------------------------
    
    by ChrisTickner at 2012-07-10T10:02:16Z
    
    Oops, I deleted the remote branch and re-pushed without realizing we'd lose some history on this PR page.  Live and learn I suppose.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-07-10T10:18:20Z
    
    Thanks!
  10. @fabpot

    merged branch bschussek/issue4102 (PR #4831)

    fabpot committed
    Commits
    -------
    
    87fe487 Revert "[Form] Add default validation to TextType field (and related)"
    
    Discussion
    ----------
    
    Revert "[Form] Add default validation to TextType field (and related)"
    
    This reverts commit 49d2685.
    
    Conflicts:
    
    	src/Symfony/Component/Form/Extension/Core/DataTransformer/ValueToStringTransformer.php
    	src/Symfony/Component/Form/Extension/Core/Type/TextType.php
    	src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/ValueToStringTransformerTest.php
    	src/Symfony/Component/Form/Tests/Extension/Core/Type/UrlTypeTest.php
  11. @jfsimon
  12. [Form] FormBuilder Bug Fix: remove() was not properly removing children

    Chris Tickner committed
    FormBuilder initially sets unresolved children as NULL, until resolved.
     If FormBuilder::remove() is called before that child is resolved, the
    if statement turns false, because isset(null) is false, when it should
    be true.  Instead, we should check to see if the key exists, and if so,
    process and unset it.
    
    Closes #4803
  13. @webmozart

    Revert "[Form] Add default validation to TextType field (and related)"

    webmozart committed
    This reverts commit 49d2685.
    
    Conflicts:
    
    	src/Symfony/Component/Form/Extension/Core/DataTransformer/ValueToStringTransformer.php
    	src/Symfony/Component/Form/Extension/Core/Type/TextType.php
    	src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/ValueToStringTransformerTest.php
    	src/Symfony/Component/Form/Tests/Extension/Core/Type/UrlTypeTest.php
  14. @fabpot
  15. @jfsimon
  16. @jfsimon
  17. @fabpot

    merged branch SamsonIT/property_path_error (PR #4829)

    fabpot committed
    Commits
    -------
    
    6ad4018 [Form] Also display the hint about adder/remover on invalid property access
    
    Discussion
    ----------
    
    [Form] Also display the hint about adder/remover on invalid property access
    
    Bug fix: no
    Feature addition: yes
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    
    This PR follows up #4777. In this case the hint about adders and removers is also added when a property is found, but is not public, a common case.
  18. @fabpot

    merged branch bschussek/optionfix (PR #4830)

    fabpot committed
    Commits
    -------
    
    c6cb8b2 [Form] Removed unused option "inline" that was introduced by accident
    
    Discussion
    ----------
    
    [Form] Removed unused option "inline" that was introduced by accident
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
  19. @webmozart
  20. [Form] Also display the hint about adder/remover on invalid property …

    Bart van den Burg committed
    …access
  21. @fabpot

    merged branch mythmakr/3686-min-max-validators-to-ignore-empty-string…

    fabpot committed
    … (PR #4188)
    
    Commits
    -------
    
    f30bf36 Min/Max Validators ignore empty string
    e9f5f13 Added test Min/Max validators should ignore empty string
    
    Discussion
    ----------
    
    [Validator] Min/Max validators should ignore empty string
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes ![Build status](https://secure.travis-ci.org/mythmakr/symfony.png?branch=3686-min-max-validators-to-ignore-empty-string)
    Fixes the following tickets: #3686
    Closed related PR #3687
    Todo:
  22. @fabpot

    Merge branch '2.0'

    fabpot committed
    * 2.0:
      [Form] Fixed errors not to be added onto non-synchronized forms
  23. @fabpot

    merged branch bschussek/issue4686 (PR #4828)

    fabpot committed
    Commits
    -------
    
    854daa8 [Form] Fixed errors not to be added onto non-synchronized forms
    
    Discussion
    ----------
    
    [Form] Fixed errors not to be added onto non-synchronized forms
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #4686
    Todo: -
  24. @webmozart
  25. @fabpot

    merged branch bschussek/issue4535 (PR #4827)

    fabpot committed
    Commits
    -------
    
    e8bb834 [Form] Fixed data to be written back by PropertyPath if it cannot be handled by reference
    
    Discussion
    ----------
    
    [Form] Fixed data to be written back by PropertyPath if it cannot be handled by reference
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #4535
    Todo: -
  26. @webmozart
  27. @fabpot
  28. @fabpot

    merged branch merk/routing-bug (PR #4823)

    fabpot committed
    Commits
    -------
    
    c061c30 Router#resolveString should return null instead of empty string when $value is null
    a1d1a02 Null default value route regression
    
    Discussion
    ----------
    
    [Router] Null default value route regression
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #4823
    Todo:
    License of the code: MIT
    Documentation PR:
    
    ---
    
    The commit by @vicb 0555913 introduces a regression in the handling of default values that are null, while there are requirements still set for this value.
    
    This is a failing test case and fix for the issue.
    
    ---------------------------------------------------------------------------
    
    by merk at 2012-07-10T04:24:40Z
    
    Now contains a fix, tests now pass.
  29. @fabpot

    merged branch zachbadgett/framework_bundle_delegating_engine (PR #4824)

    fabpot committed
    Commits
    -------
    
    2fa98e8 [FrameworkBundle] Changed DelegatingEngine::renderResponse to use specified engine's renderResponse
    
    Discussion
    ----------
    
    [FrameworkBundle] Changed DelegatingEngine::renderResponse to use specified engine's renderResponse
    
    Currently the DelegatingEngine in the FrameworkBundle has a renderResponse method that creates a new response, it should use the engine's renderResponse since EngineInterface requires a renderResponse to be defined and gives more flexibly to change the response object when creating a new templating engine.
    
    Bug fix: no
    Feature addition: yes
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    License of the code: MIT
    Documentation PR: -
  30. @fabpot

    merged branch bschussek/issue3899 (PR #4813)

    fabpot committed
    Commits
    -------
    
    9c94b48 [Form] Fixed the "data" option to supersede default data set in the model
    
    Discussion
    ----------
    
    [Form] Fixed the "data" option to supersede default data set in the model
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #3899
    Todo: -
  31. @fabpot

    merged branch bschussek/bind_request (PR #4811)

    fabpot committed
    Commits
    -------
    
    7727de7 [Form] Deprecated Form::bindRequest() and replaced it by a PRE_BIND listener
    
    Discussion
    ----------
    
    [Form] Deprecated Form::bindRequest() and replaced it by a PRE_BIND listener
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    
    Instead of `bindRequest`, you should now simply call `bind`:
    
    Before:
    
    ```
    $form->bindRequest($request);
    ```
    
    After:
    
    ```
    $form->bind($request);
    ```
  32. @fabpot

    merged branch fixe/patch-4 (PR #4821)

    fabpot committed
    Commits
    -------
    
    c4d4d2e Removed extra new line
    
    Discussion
    ----------
    
    Removed extra new line
  33. @fabpot

    merged branch fixe/patch-5 (PR #4822)

    fabpot committed
    Commits
    -------
    
    f5cf28f Updated Portuguese translation
    
    Discussion
    ----------
    
    Updated Portuguese translation
    
    Based on #4820
  34. @fabpot

    merged branch eriksencosta/pt-br-translation (PR #4820)

    fabpot committed
    Commits
    -------
    
    19cdc8f updated Brazilian Portuguese translation
    
    Discussion
    ----------
    
    updated Brazilian Portuguese translation
Something went wrong with that request. Please try again.