Skip to content
This repository was archived by the owner on Dec 5, 2020. It is now read-only.

Conversation

@wslulciuc
Copy link
Member

This PR adds API key support to our client. For more details see MarquezProject/marquez#817. This PR also fixes a bug to the HTTP backend when using the default marquez URL.

Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #119 into main will increase coverage by 2.45%.
The diff coverage is 56.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   38.16%   40.62%   +2.45%     
==========================================
  Files          21       22       +1     
  Lines         862      901      +39     
==========================================
+ Hits          329      366      +37     
- Misses        533      535       +2     
Impacted Files Coverage Δ
marquez_client/backend.py 0.00% <ø> (ø)
marquez_client/client.py 0.00% <0.00%> (ø)
marquez_client/clients.py 0.00% <0.00%> (ø)
marquez_client/constants.py 0.00% <0.00%> (ø)
marquez_client/http_backend.py 0.00% <0.00%> (ø)
marquez_client/utils.py 0.00% <0.00%> (ø)
tests/test_marquez_clients.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19d8129...8e87661. Read the comment docs.

@wslulciuc wslulciuc merged commit 0e79cda into main Oct 21, 2020
@wslulciuc wslulciuc deleted the feature/api-key branch October 21, 2020 20:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants