Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue-343 #364

Merged
merged 6 commits into from Mar 1, 2019

Conversation

@hjpatel16
Copy link
Contributor

commented Mar 1, 2019

Removed the @JsonProperty from api models in DatasetResponse.java, DatasetsResponse.java, ErrorResponse.java, Job.java, JobRunRequest.java, JobRunResponse.java, NamespaceResponse.java, NamespacesResponse.java

hjpatel16 added 4 commits Mar 1, 2019
…ava, DatasetsResponse.java, ErrorResponse.java, Job.java, JobRunRequest.java, JobRunResponse.java, NamespaceResponse.java, NamespacesResponse.java
@wslulciuc

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

Thanks, @hjpatel16! Looks like you have some minor formatting issues that's causing the build to fail. They can easily be fixed with:

$ ./gradlew spotlessApply
import java.util.List;
import lombok.Data;
import lombok.NonNull;

@Data
public final class DatasetsResponse {
@NonNull
@JsonProperty("datasets")
private final List<DatasetResponse> datasetResponses;

This comment has been minimized.

Copy link
@wslulciuc

wslulciuc Mar 1, 2019

Member

Unfortunately, @JsonProperty is required here because we're telling jackson to override the name datasetResponses with datasets when serializing the class as Json. In order to remove @JsonProperty, let's rename the field as:

List<DatasetResponse> datasets;

This comment has been minimized.

Copy link
@hjpatel16

hjpatel16 Mar 1, 2019

Author Contributor

Fixed it.. Thanks for the help!!

@codecov

This comment has been minimized.

Copy link

commented Mar 1, 2019

Codecov Report

Merging #364 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #364   +/-   ##
========================================
  Coverage      77.2%   77.2%           
  Complexity      398     398           
========================================
  Files            91      91           
  Lines          1044    1044           
  Branches         50      50           
========================================
  Hits            806     806           
  Misses          172     172           
  Partials         66      66
Impacted Files Coverage Δ Complexity Δ
src/main/java/marquez/api/models/Job.java 88.88% <ø> (ø) 8 <0> (ø) ⬇️
...rc/main/java/marquez/api/models/ErrorResponse.java 66.66% <ø> (ø) 2 <0> (ø) ⬇️
...ain/java/marquez/api/models/NamespaceResponse.java 85.71% <ø> (ø) 6 <0> (ø) ⬇️
.../main/java/marquez/api/models/DatasetResponse.java 50% <100%> (ø) 4 <2> (ø) ⬇️
...in/java/marquez/api/models/NamespacesResponse.java 60% <100%> (ø) 3 <1> (ø) ⬇️
...c/main/java/marquez/api/models/JobRunResponse.java 87.5% <100%> (ø) 7 <1> (ø) ⬇️
...main/java/marquez/api/models/DatasetsResponse.java 50% <100%> (ø) 1 <1> (ø) ⬇️
...rc/main/java/marquez/api/models/JobRunRequest.java 83.33% <100%> (ø) 5 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d74277...e927273. Read the comment docs.

@hjpatel16

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2019

Requested changes are made. Thanks

Copy link
Member

left a comment

Thanks, @hjpatel16!

@wslulciuc wslulciuc merged commit 4149738 into MarquezProject:master Mar 1, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 77.2%)
Details
codecov/project 77.2% (+0%) compared to 7c6431b
Details
@wslulciuc wslulciuc referenced this pull request Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.