Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue #358 02: rename class job #381

Merged
merged 9 commits into from Mar 4, 2019

Conversation

@Violet-XiaoWeiHuang
Copy link
Contributor

commented Mar 4, 2019

Rename Job => JobResponse
Update all imports from marquez.api.models.Job to marquez.api.models.JobResponse

@wslulciuc

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

These changes are looking much better, @Violet-XiaoWeiHuang! I think you just have to apply formatting to the code, then we'll be good to merge:

$ ./gradlew spotlessApply
@Violet-XiaoWeiHuang

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

Hi @wslulciuc,
Please review my commit.
I try $ ./gradlew spotlessApply locally

image

I am not sure why issues on src/test/java/marquez/api/JobIntegrationTest.java and 'src/test/java/marquez/api/JobTest.java' which are related to my commit.

Thanks

@wslulciuc

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

I try $ ./gradlew spotlessApply locally

Nice! So, after running the gradle task spotlessApply to format your code locally, you'll then want to stage and commit you changes. This will fix the broken CI build

@codecov

This comment has been minimized.

Copy link

commented Mar 4, 2019

Codecov Report

Merging #381 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #381   +/-   ##
========================================
  Coverage      77.2%   77.2%           
  Complexity      398     398           
========================================
  Files            91      91           
  Lines          1044    1044           
  Branches         50      50           
========================================
  Hits            806     806           
  Misses          172     172           
  Partials         66      66
Impacted Files Coverage Δ Complexity Δ
...c/main/java/marquez/api/resources/JobResource.java 88.09% <ø> (ø) 20 <0> (ø) ⬇️
src/main/java/marquez/api/models/JobResponse.java 88.88% <ø> (ø) 8 <0> (?)
src/main/java/marquez/api/models/JobsResponse.java 75% <100%> (ø) 3 <1> (ø) ⬇️
...ava/marquez/api/mappers/ApiJobToCoreJobMapper.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...ava/marquez/api/mappers/CoreJobToApiJobMapper.java 100% <100%> (ø) 2 <2> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e740ded...22ec9b0. Read the comment docs.

Copy link
Member

left a comment

@wslulciuc wslulciuc merged commit 9d9e78c into MarquezProject:master Mar 4, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 77.2%)
Details
codecov/project 77.2% (+0%) compared to e740ded
Details
@wslulciuc wslulciuc referenced this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.