Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound {namespace} to NamespaceName #391

Merged
merged 8 commits into from Mar 7, 2019

Conversation

@pbrahmbhatt3
Copy link
Contributor

commented Mar 6, 2019

Bound {namespace} in path variable of resource files to NamespaceName.

@codecov

This comment has been minimized.

Copy link

commented Mar 6, 2019

Codecov Report

Merging #391 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #391      +/-   ##
============================================
+ Coverage     76.54%   76.61%   +0.06%     
  Complexity      394      394              
============================================
  Files            90       90              
  Lines          1019     1022       +3     
  Branches         48       48              
============================================
+ Hits            780      783       +3     
  Misses          172      172              
  Partials         67       67
Impacted Files Coverage Δ Complexity Δ
.../java/marquez/api/resources/NamespaceResource.java 94.73% <100%> (ø) 6 <0> (ø) ⬇️
...in/java/marquez/api/resources/DatasetResource.java 86.66% <100%> (+0.95%) 5 <2> (ø) ⬇️
...c/main/java/marquez/api/resources/JobResource.java 97.05% <100%> (+0.08%) 19 <10> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0063d3...79f76fd. Read the comment docs.

@pbrahmbhatt3

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

@wslulciuc Hey. Sorry to bug you so much but I forgot to ad a review tag to this pull request. Could you please review it? Thank you. :)

@wslulciuc

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

@pbrahmbhatt3: It's no trouble at all. I reviewed your patch, everything looks great! I had to merge recent master changes into your branch. Mind formatting your code with:

$ ./gradlew spotlessApply

then pushing the change to your branch? That should fix the failing build and we can get your PR merged!

@pbrahmbhatt3

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

Sure👍

Priyam Brahmbhatt
@wslulciuc
Copy link
Member

left a comment

@wslulciuc wslulciuc merged commit 41cc011 into MarquezProject:master Mar 7, 2019

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 76.54%)
Details
codecov/project 76.61% (+0.06%) compared to e0063d3
Details
@wslulciuc

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Closes #374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.