Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes-319 #442

Merged
merged 4 commits into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@hjpatel16
Copy link
Contributor

commented Apr 11, 2019

Added DataSourceRowMapperTest

@codecov

This comment has been minimized.

Copy link

commented Apr 11, 2019

Codecov Report

Merging #442 into master will decrease coverage by 1.84%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #442      +/-   ##
============================================
- Coverage     79.96%   78.11%   -1.85%     
+ Complexity      514      470      -44     
============================================
  Files           109      103       -6     
  Lines          1308     1170     -138     
  Branches         59       50       -9     
============================================
- Hits           1046      914     -132     
- Misses          167      174       +7     
+ Partials         95       82      -13
Impacted Files Coverage Δ Complexity Δ
.../java/marquez/db/mappers/DbTableInfoRowMapper.java 12.5% <0%> (-87.5%) 1% <0%> (-3%)
src/main/java/marquez/service/DatasetService.java 10.34% <0%> (-59.02%) 2% <0%> (-10%)
...java/marquez/service/mappers/DatasetRowMapper.java 0% <0%> (-43.48%) 0% <0%> (-1%)
src/main/java/marquez/db/models/DatasetRow.java 50% <0%> (-40.91%) 8% <0%> (-3%)
src/main/java/marquez/service/models/Dataset.java 50% <0%> (-35.72%) 4% <0%> (-3%)
...api/exceptions/DatasourceUrnNotFoundException.java 66.66% <0%> (-33.34%) 1% <0%> (ø)
src/main/java/marquez/db/models/DatasourceRow.java 55.55% <0%> (-30.16%) 7% <0%> (+1%)
...ez/service/exceptions/MarquezServiceException.java 14.28% <0%> (-28.58%) 1% <0%> (-1%)
src/main/java/marquez/MarquezException.java 14.28% <0%> (-28.58%) 1% <0%> (-1%)
...c/main/java/marquez/service/models/Datasource.java 57.14% <0%> (-26.2%) 5% <0%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2301584...48fa48d. Read the comment docs.

hjpatel16 and others added some commits Apr 11, 2019

@wslulciuc wslulciuc merged commit ba45353 into MarquezProject:master Apr 12, 2019

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
@wslulciuc

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Minor: This is actually a test for DbTableVersionRowMapper. In your PR description it says DataSourceRowMapperTest :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.