Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DbTableVersionRowMapperTest.java in service package #450

Merged
merged 6 commits into from Apr 14, 2019

Conversation

Projects
None yet
2 participants
@hjpatel16
Copy link
Contributor

commented Apr 12, 2019

No description provided.

hjpatel16 added some commits Apr 12, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 13, 2019

Codecov Report

Merging #450 into master will increase coverage by 1.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #450      +/-   ##
============================================
+ Coverage     81.03%   82.41%   +1.37%     
- Complexity      524      528       +4     
============================================
  Files           109      109              
  Lines          1308     1308              
  Branches         58       59       +1     
============================================
+ Hits           1060     1078      +18     
+ Misses          152      128      -24     
- Partials         96      102       +6
Impacted Files Coverage Δ Complexity Δ
.../java/marquez/api/resources/NamespaceResource.java 94.44% <0%> (ø) 5% <0%> (ø) ⬇️
...c/main/java/marquez/api/resources/JobResource.java 97.05% <0%> (ø) 19% <0%> (ø) ⬇️
...java/marquez/service/mappers/DatasetRowMapper.java 69.56% <0%> (+26.08%) 2% <0%> (+1%) ⬆️
...rquez/service/mappers/DbTableVersionRowMapper.java 77.77% <0%> (+77.77%) 2% <0%> (+2%) ⬆️
.../marquez/service/mappers/DbTableInfoRowMapper.java 83.33% <0%> (+83.33%) 1% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de4f7ee...099e0b0. Read the comment docs.

@wslulciuc
Copy link
Member

left a comment

LGTM 👍

@hjpatel16: In future PRs, please link the issue # in your pull request description, see: https://help.github.com/en/articles/closing-issues-using-keywords and our CONTRIBUTING.md

@wslulciuc wslulciuc merged commit 01cce2d into MarquezProject:master Apr 14, 2019

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.