New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.0.0 UI lag #1777

Closed
meow81 opened this Issue Oct 16, 2016 · 113 comments

Comments

Projects
None yet
@meow81
Copy link

meow81 commented Oct 16, 2016

Since updating to v4.0.0, I'm experiencing a lot of lag with the UI catching up with the mouse cursor position and selectable elements of UI like play buttons when hovering over an album cover not showing or very delayed, volume slider delayed appearance, and menu items highlighted background color that shows when you are hovering over it very delayed.

The product unfortunately feels broken in this version. Should I try a reinstall? Let me know what additional info I can provide.

see the video for detail and pay attention to the mouse cursor:
https://youtu.be/HfmpdkQb82o

forgot to show proof of the version in the video, but took a screen shot afterwards:
image

My system info:
Windows 10.0.14393 x64
Processor AMD FX-8370 Eight-Core Processor, 4000 Mhz, 4 Core(s), 8 Logical Processor(s)
8.00 GB RAM
NVIDIA GeForce GTX 950

where is this in the FAQs? I looked, but it's not listed on that page.

If appropriate please attach the DEBUG information zip file that you can generate by following the instructions in the FAQ
(https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/FAQ)

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Oct 16, 2016

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Oct 16, 2016

Regardless however can you try clearing your cache completely.

Delete the %APPDATA%\Google Play Music Desktop Player folder 👍

@seaneking

This comment has been minimized.

Copy link

seaneking commented Oct 16, 2016

I'm seeing a lot of UI lag and glitches with 4.0 as well. The glitches in particular make it really hard to use, the screen flashes white or tears.

Clearing application data didn't help.

On Macbook Pro 2015, MacOS Sierra latest. Debug info here: debug_info.zip

In the meantime is there a way to roll back to 3.x and turn off auto updates? In general it would be nice to opt-in to major version bumps (apologies if I just missed a setting for this somewhere).

@meow81

This comment has been minimized.

Copy link

meow81 commented Oct 17, 2016

debug info:
debug_info.zip

delete this folder? I didn't notice any difference after clearing the contents of the folder.
image

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Oct 17, 2016

@meow81 Delete the entire Google Play Music Desktop Player folder.

@meow81

This comment has been minimized.

Copy link

meow81 commented Oct 17, 2016

tried that. It didn't work.

@Smashman

This comment has been minimized.

Copy link

Smashman commented Oct 17, 2016

I am also seeing this issue on Mac OSX.

Could be related to the new UI changes made?

@meow81

This comment has been minimized.

Copy link

meow81 commented Oct 17, 2016

just noticed the v4.0.1, updated, not sure if that has anything to do with this issue or not. Regardless, I cleared cache as instructed before and experience the same lag issues. Possibly a slight improvement, but the mouse cursor and UI are still not in sync. UI elements are jumpy and flashing under the mouse cursor and selections are still a bit behind where my mouse actually is.

@boulund

This comment has been minimized.

Copy link

boulund commented Oct 18, 2016

I'm experiencing the same issues with the recent update. It wasn't perfect before, but the two most recent updates unfortunately really destroyed usability for me :(.
Running Windows 10 Insider Preview on a Lenovo X1 Yoga (Core i7-6600U 2.81Ghz, 16GB RAM, 512GB SSD).

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Oct 18, 2016

Guys to determine where the issue is. Can you download raw Electron from here

https://github.com/electron/electron/releases/download/v1.4.3/electron-v1.4.3-win32-ia32.zip

And open the dev tools console and run the following command

window.location = "https://play.google.com/music/listen#/now"

Then play around and see if the UI lag is present.

@boulund

This comment has been minimized.

Copy link

boulund commented Oct 18, 2016

Using the raw Electron release makes a WORLD of difference. Still not 100% perfect (just like most Electron-based apps I've used unfortunately--but probably not because of Electron in this case; the gplay website is slow for me as well), but a massive difference.

@meow81

This comment has been minimized.

Copy link

meow81 commented Oct 19, 2016

agree with @boulund. It was night and day, only experienced a small delay once or twice, but noticeably better experience.

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Oct 19, 2016

Hm, without a device to reproduce the issue tracking down the lag will be tricky. Can someone run a CPU profile from dev tools and upload it here?

@meow81

This comment has been minimized.

Copy link

meow81 commented Oct 19, 2016

I'm embarrassed to admit, but how do I do that? I will, just need a little guidance. This app is amazing and I'll do whatever to help out.

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Oct 19, 2016

Type DEV_MODE into the go to URL modal.

Relaunch GPMDP

Open dev tools with the standard chrome shortcut.

Click profiles

Click "start". Do some stuff for 30 seconds. Click "stop"

Upload it here

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Oct 19, 2016

@meow81 That profile appears to be from the webview not the main window. Can you upload a profile for the main window?

@meow81

This comment has been minimized.

Copy link

meow81 commented Oct 19, 2016

I'm having trouble running the app to get dev mode. I'm not sure what I did originally was correct. Should I be using Electron?

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Oct 19, 2016

No you should be using GPMDP.

I'll try be more clean with the steps.

  1. Open GPMDP
  2. Use the shortcut "Control + Shift + G"
  3. Type in "DEV_MODE"
  4. Click "Let's Go"
  5. Relaunch GPMDP
  6. Use the dev tools shortcut "Control + Shift + I"
  7. Use the profiles tab to make a CPU profile
@seaneking

This comment has been minimized.

Copy link

seaneking commented Oct 19, 2016

CPU-20161019T181635.cpuprofile.zip

Funnily enough the UI was reasonably smooth while recording that profile, maybe intermittent?

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Oct 19, 2016

@seaneking I can't see any obvious issues with that profile. Perhaps wait till it gets really bad and then start the profile 👍

@boulund

This comment has been minimized.

Copy link

boulund commented Oct 19, 2016

Here's a profile from me. It was fairly slow during the recording, but probably not as slow as it has been at its worst before.

CPU-20161019T120723.zip

@hydrocane

This comment has been minimized.

Copy link

hydrocane commented Oct 19, 2016

Here is another profile. The recording was the same as if I used the application normally with the lag.

CPU-20161019T062455.zip

I did find an error in the dev tools as well, not sure what it means:

"C:\Users\hydro\AppData\Local\GPMDP_3\app-4.0.1\resources\electron.asar\renderer\web-view\web-view.js:294 ::shadow pseudo-element is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details."

@seaneking

This comment has been minimized.

Copy link

seaneking commented Oct 19, 2016

@hydrocane that's just a deprecation warning for the ::shadow selector, wouldn't effect UI lag.

@meow81

This comment has been minimized.

Copy link

meow81 commented Oct 19, 2016

CPU-20161019T191543.zip

Okay got it this time. Have to say, running in DEV_MODE reduces much of the lag, so the capture won't be a good representation of what I experience running in a normal mode. When I switched back the lag returned to a pretty severe level.
Also, noticed that randomly now when I open the app it appears to just be displaying the web UI of google play music and no desktop app settings are present, not even the menu. Restarting the app fixes it.

image

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Oct 19, 2016

Also, noticed that randomly now when I open the app it appears to just be displaying the web UI of google play music and no desktop app settings are present, not even the menu. Restarting the app fixes it.

Getting the errors from console would help a lot with figuring out this issue. Someone weird is happening somewhere

@Tenzinn3

This comment has been minimized.

Copy link

Tenzinn3 commented Oct 20, 2016

Screen glitches on MacOS: https://vid.me/hsPY

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Oct 20, 2016

@meow81 That log appears to indicate some kind of event loop, i.e. an event causing another event to be fired and react's event batching is working overtime to handle it.

It's gonna be hard to track this down 🍆

@lucaseverett

This comment has been minimized.

Copy link

lucaseverett commented Oct 20, 2016

In addition to the lag I'm seeing some other strange issues with version 4. I'm having frames drop. Animations appear to be around 10 to 20 frames per second. (I have an AMD RX 470 and had no issues with version 3.6.)

Also, when I'm in an album and hover over a song, the hover effect is showing on the wrong song. For example, when I hover over song #1 in an album, it shows the hover effect on #8.

In the following screenshot, I had my cursor over song #1.

hover

@boulund

This comment has been minimized.

Copy link

boulund commented Nov 10, 2016

Sorry to say, it doesn't work well at all. Interface is laggy, mouse-over effects jump around all over the place.

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 10, 2016

@boulund Can you try launching the .exe file from CMD like so.

"Google Play Music Desktop Player.exe" --enable-use-zoom-for-dfs=false -- --enable-use-zoom-for-dfs=false

EDIT: Uploading a new build now, I totally screwed up the other one

@MarshallOfSound

This comment has been minimized.

@boulund

This comment has been minimized.

Copy link

boulund commented Nov 10, 2016

No mouse jitters! Performance is also good when not maximized. Still rather sluggish when maximized on my second monitor (2560x1440), but that might be because of my machine being a laptop with a weaker processor...

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 10, 2016

@boulund Sweet, good to hear that I finally tracked it down 😆

Fix should go out next release 👍 Until then feel free to use that build I just uploaded 😄

@boulund

This comment has been minimized.

Copy link

boulund commented Nov 10, 2016

So, what was the cause?

Edit: nvm, see it now! :)

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 10, 2016

@boulund Chromium 53 changed the way they handle display scaling on renderer windows. They automatically enabled the enable-use-zoom-for-dsf flag which apparently doesn't cope with webviews very well. Forcing that flag off fixed the issue 👍

See the commit I just pushed for reference.

@ericralph

This comment has been minimized.

Copy link

ericralph commented Nov 11, 2016

At least for me, the 11/10 build was much worse than the previous one.
Very, very laggy and could not even get the hover interaction aspects to
work at all.

On Thu, Nov 10, 2016 at 5:27 AM, Samuel Attard notifications@github.com
wrote:

@boulund https://github.com/boulund Chromium 53 changed the way they
handle display scaling on renderer windows. They automatically enabled the
enable-use-zoom-for-dsf flag which apparently doesn't cope with webviews
very well. Forcing that flag off fixed the issue 👍

See the commit I just pushed for reference.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1777 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANP6WWPnpEMhjylgu6Z3Y7VFWbfwuBvLks5q8xvIgaJpZM4KYGh2
.

Eric Ralph
Science, Technology, & Society w/ Bioethics Emphasis | 2017
University of Puget Sound
3418 N Ferdinand St,
Tacoma, WA 98407
eralph@pugetsound.edu
303.990.0977

@meow81

This comment has been minimized.

Copy link

meow81 commented Nov 13, 2016

@wcomartin

This comment has been minimized.

Copy link

wcomartin commented Nov 14, 2016

anyway to make a MacOS Siera version of this build or is this going into the mainline soon?

@donewert

This comment has been minimized.

Copy link

donewert commented Nov 14, 2016

I just upgraded to the latest (4.0.3) on Sierra. The problems persist there. Would be happy to test any builds if needed.

@wcomartin

This comment has been minimized.

Copy link

wcomartin commented Nov 14, 2016

the latest build actually seems worse than 4.0.2, i cant even see the queue or the left nav anymore.

edit:
works fine on my 1080p monitor, but the Macbook Pro Retina screen is a no go

@seaneking

This comment has been minimized.

Copy link

seaneking commented Nov 14, 2016

4.0.3 still broken for me too

@jostrander

This comment has been minimized.

Copy link
Collaborator

jostrander commented Nov 14, 2016

@seaneking @wcomartin Are you using High DPI Displays? (4k, retina, etc?)

@wcomartin

This comment has been minimized.

Copy link

wcomartin commented Nov 15, 2016

When I have the issue it is on my retina screen, the 1080 doesn't have the issue

@donewert

This comment has been minimized.

Copy link

donewert commented Nov 15, 2016

The windows version is a little laggy on my 4K screen, but not glitchy. The Mac version on Retina flashes so much I had to shut it off. 1080P seems fine, however, no background images (e.g. artists in a playlist) show up anymore. The regular web site is fine.

@seaneking

This comment has been minimized.

Copy link

seaneking commented Nov 15, 2016

I'm on a retina MacBook, and yep Super glitchy

@lucaseverett

This comment has been minimized.

Copy link

lucaseverett commented Nov 15, 2016

@MarshallOfSound With 4.0.3 and Windows 10, the mouse cursor glitches are gone, but it is still very laggy, low framerate animations, and background images are not showing up. However, in the last build you posted in this thread a few days ago, the background images do load. The lag/framerate is the same, though. Also, I noticed that the background images still don't show up even if I turn off Windows scaling.

All around, 3.6 is much more pleasant to use -- no issues at all. Thanks for sharing the trick with the hosts file.

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 15, 2016

@lucaseverett Without any way for me to replicate the low framerate issues I can't even begin to come up with a solution. It is probably an underlying Chromium issue that will be handled by the bump to 54 which is slowly being worked towards over at electron/electron.

Regarding the background images that is due to my quick patch to get the dark theme and other functionality working on the latest google play music UI update. I have more finely tuned fixes coming shortly but it was like 2am and I couldn't be bothered putting in the hours to get it working nicely so I went for "just working" 😆

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 15, 2016

To further explain my dilemma for anyone reading these. I am faced with a choice. Currently we are on Electron 1.4.4, the last known version that didn't have these issues was 1.3.6. Now with that in mind, you would obviously go "Hey, why not downgrade". Which was my first thought as well, the problem is, 1.4.4 fixed two other crash bugs.

I.e. Downgrading to 1.3.6 would break more clients than it would "fix".

@seaneking

This comment has been minimized.

Copy link

seaneking commented Nov 15, 2016

Does the issue persist with a naked Electron wrapper? I thought we ruled that out.

In any case, I think this issue should be reopened. It's obviously still effecting a lot of users.

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 15, 2016

Does the issue persist with a naked Electron wrapper?

The issue itself is running any website through a webview. So anyone running the site just in Electron won't notice it unless you go through the trouble of setting up a webview element to test in.

In any case, I think this issue should be reopened. It's obviously still effecting a lot of users.

It's hard to tell how many and I don't think it is the same issue. There is no way that the fix only worked for a portion of the users. There must be at least two separate problems. I think that everyone experiencing "UI glitches" saw this issue and jumped on board saying "me too" "me too" when I think there are multiple issues at play here.

For instance, there is the issue I just fixed (High DPI on Windows inside a WebView) but there is another issue in this thread for touchscreen devices in a WebView. I think for my sanity's sake you should raise a new issue with the following information.

Host OS:
Host OS Version:
Display Resolution:
Display DPI:
Touchscreen: Yes / No
Clean and concise description:
Video clearly showing problem:

Then I can start categorizing these issues correctly. In addition, ANYONE jumping onto a thread with a comment like "me too" or "same here" or "can this be fixed" will be deleted and if you do it more than once you will be blocked from the repo. I get that lots of you are having this issue but this thread is a prime example of what NOT to do, there are over 100 comments most of which are just repeats of ones before or contain 0 additional / helpful information. If you agree with someone, give them the thumbs up reaction, don't add a new comment

End Rant

@donewert

This comment has been minimized.

Copy link

donewert commented Nov 15, 2016

Host OS: MacOS 10
Host OS Version: Sierra
Display Resolution: Retina - External monitor, no problmes
Display DPI: Scaled, more space
Touchscreen: No
Clean and concise description: Background white flashing, kind of like all pixels going white then back to whatever the background is. Especially noticeable when background images are loading.
Video clearly showing problem: I will try and upload later.

I also use windows 10 at home, on a 4k screen and do not see any issues worth complaining about that you have not already addressed.

I appreciate your effort and as a fellow dev, fully understand your frustration.

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 15, 2016

@donewert

raise a new issue

@meow81

This comment has been minimized.

Copy link

meow81 commented Nov 15, 2016

@MarshallOfSound while I understand your point, the me toos and same here comments at least give you an indication of the scale of the issue. Otherwise how would you get a sense of the impact and be able to prioritize appropriately? However, I realize that doesn't provide you any information to troubleshoot with and I can understand that being frustrating.

Also, what other alternative besides Github is there to report issues for this software? Not all of the end users are developers and may not be comfortable or know what to provide here on Github. I opened up an account just to report the issue and tried my best to provide some useful info. I guess what I'm saying is to appreciate users reaching out to you to provide feedback even if it's not in the ideal format. I work in software/web development, but on the project management side (not a developer) so I can understand the frustrations about receiving feedback when there's not much info provided or feedback that can be perceived as a complaint.

Is there anything else I can help test regarding the original issue? Or do you think that's resolved now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment