New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI broken after latest Google update #1894

Closed
FezVrasta opened this Issue Nov 14, 2016 · 34 comments

Comments

Projects
None yet
6 participants
@FezVrasta
Copy link

FezVrasta commented Nov 14, 2016

I'm just reporting this to bring it to your attention.

image

image

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 14, 2016

@chrismou

This comment has been minimized.

Copy link
Contributor

chrismou commented Nov 14, 2016

Holy fragoles!

That's what I get for not restarting my player for a few days 😱

Cheers for the heads up!

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 14, 2016

@chrismou Only just happened AFAIK I restarted my player not 2 hours ago and still had the old UI.

@chrismou

This comment has been minimized.

Copy link
Contributor

chrismou commented Nov 14, 2016

FWIW, IMO the new front page is fuuugly

Who was that guy on here who worked for Google? I need to get him to tell the gmusic team I'm not happy 😂

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 14, 2016

FWIW, IMO the new front page is fuuugly

I agree, currently patching gmusic-theme.js now. It looks like gmusic.js itself though is still working.

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 14, 2016

It doesn't help that even without modifications their new UI is buggy and doesn't work correctly....

@FezVrasta

This comment has been minimized.

Copy link

FezVrasta commented Nov 14, 2016

I see some random white flashes by time in time

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 14, 2016

@FezVrasta I'm getting those as well, appears to be on GPM's side of things as I get them without the theme enabled. Strange white lines at the top of the screen. Making progress on fixing the theming.

gmusic-utils/gmusic-theme.js@584e135

Just checking the light theme now

@MarshallOfSound MarshallOfSound self-assigned this Nov 14, 2016

@jostrander

This comment has been minimized.

Copy link
Collaborator

jostrander commented Nov 14, 2016

Hopefully they aren't tampering with it at the moment as well or we'll have to do this all over again soon.

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 14, 2016

Also took the liberty in our theming library of killing the stupid amount of padding they added between blocks. 148px seemed a bit much

@MarshallOfSound MarshallOfSound referenced this issue Nov 14, 2016

Closed

Version 4.0.3 - Patch Release #1895

10 of 10 tasks complete
@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 14, 2016

4.0.3 is being cooked up by the CI agents right now 👍

@chrismou

This comment has been minimized.

Copy link
Contributor

chrismou commented Nov 14, 2016

Is there a way of forcing an update check on the linux client? I ran into this the other day, where I ended up just downloading the new version manually and installing over the top

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 14, 2016

@chrismou There isn't an auto-update on the linux client still

Not sure the auto-update part is technically possible and I've never had the effort to make a simple update check / notification thing 😢

So yeah, for now, install over 👍 😆

@chrismou

This comment has been minimized.

Copy link
Contributor

chrismou commented Nov 14, 2016

If I end up staying on Linux much longer, maybe I'll set up a Debian repository so we can install and update it with apt 😂

https://wiki.debian.org/SettingUpSignedAptRepositoryWithReprepro

@jostrander

This comment has been minimized.

Copy link
Collaborator

jostrander commented Nov 14, 2016

We actually have an apt repo somewhere in the abyss... @MarshallOfSound would know where at

@chrismou

This comment has been minimized.

Copy link
Contributor

chrismou commented Nov 14, 2016

Oh cool, so there is a way of getting updates through - just not how I installed it 😂

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 14, 2016

👍

@chrismou

This comment has been minimized.

Copy link
Contributor

chrismou commented Nov 14, 2016

Although saying that, it's stuck on 3.2.4

@chrismou

This comment has been minimized.

Copy link
Contributor

chrismou commented Nov 14, 2016

I should probably stick this in another issue ticket, if it's actually an issue. Sorry, polluting this closed ticket...

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 14, 2016

@chrismou I just published 4.0.3 on that bintray repo. It should be up there (might take a while for the CDN to update). The 4.x releases never hit it because my auto-upload thing only handled 3.x 😆

@chrismou

This comment has been minimized.

Copy link
Contributor

chrismou commented Nov 14, 2016

Interestingly though, the Debian package has already updated (https://dl.bintray.com/marshallofsound/deb/dists/debian/main/binary-amd64/Packages

Anyways, I've switched the sources file to use that and it looks to be pulling the latest update through. Sweeet. 😄

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 14, 2016

👍 Anyway, I'm off to bed. Thanks for the panic attack Google 😆

@FezVrasta

This comment has been minimized.

Copy link

FezVrasta commented Nov 15, 2016

I'm still having problems guys:

image

image
image

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 15, 2016

@FezVrasta See gmusic-utils/gmusic-theme.js#60

The last 2 images I can see the issue and it has been fixed in that issue mentioned above. I can't see what the issue is in the first image 👍

@FezVrasta

This comment has been minimized.

Copy link

FezVrasta commented Nov 15, 2016

In the first image, the navigation dots are white on a super light grey background and are almost invisible. They should probably be of the same color of the accent (in my case, dark gray)

To note that I'm already on 4.0.3

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 15, 2016

@FezVrasta How did you get a white background behind those dots? (Like which page)

@FezVrasta

This comment has been minimized.

Copy link

FezVrasta commented Nov 15, 2016

It's the main page with the light theme.

image

@FezVrasta

This comment has been minimized.

Copy link

FezVrasta commented Nov 15, 2016

I see that, in some sections, the dots are correctly white, but probably they should change based on the context (I guess the native Google Music interface already addresses this problem)

image

@FezVrasta

This comment has been minimized.

Copy link

FezVrasta commented Nov 15, 2016

This is the behaviour in the web interface:

web-ui

@MarshallOfSound

This comment has been minimized.

Copy link
Owner

MarshallOfSound commented Nov 15, 2016

@FezVrasta Yep I just adjusted the theme to only override the page indicator fill color on the dark theme. (The CSS had ended up in the common file for some reason). All the issues you mentioned are now fixed upstream 👍

@FezVrasta

This comment has been minimized.

Copy link

FezVrasta commented Nov 15, 2016

Great 😬

@deletescape

This comment has been minimized.

Copy link

deletescape commented Nov 21, 2016

image
If I leave GPMDP in the background and reopen it after sometime the background on the Home page sometimes changes back to white for some reason.

Didn't open a new issue because it looks similar to some other issue which has been discussed in here. If you want a new issue for this I can open one.

Win 7 Enterprise x64
I'm on the latest successfull CI build

@mafuchi

This comment has been minimized.

Copy link

mafuchi commented Apr 19, 2018

I am having this padding issue on 4.5.0, I experience it only windows 10 (MacOS seems to be fine).
I have custom scaling set to 175% in windows on a 1080p display (maybe this is relevant?), though this was not an issue in the past.
Let me know if you need any other information.

musicplayer

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment