New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Open share links #3095

Open
jasekiw opened this Issue Apr 18, 2018 · 9 comments

Comments

Projects
None yet
4 participants
@jasekiw

jasekiw commented Apr 18, 2018

When ever I click on a shared google play music link (The link generated when hitting share on a song), I would like there to be some way to open the destination in the desktop player.

Current workaround:

  • Open the share link in the browser.
  • Read the name of the artist and song name
  • Search this in the desktop player

This would make is much easier to listen to music sent from friends.

@welcome

This comment has been minimized.

welcome bot commented Apr 18, 2018

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already.
To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

@jostrander

This comment has been minimized.

Collaborator

jostrander commented Apr 19, 2018

This is already possible, but a little less obvious. If you press ctrl+shift+g in the player you can paste the share URL and the player will navigate to the shared link. I don't believe we can register url handlers for play music because http is already registered, and we can't register anything more specific than that.

@jasekiw

This comment has been minimized.

jasekiw commented Apr 19, 2018

I don't see that hotkey on the hotkeys settings page, that would be a good place to add this.

I just tried it but for some reason it doesn't do anything after hitting Let's Go. The dialog disappears but it doesn't navigate anywhere.

@jostrander

This comment has been minimized.

Collaborator

jostrander commented Apr 19, 2018

What link are you trying to navigate to? That dialog does have some guarding so you can't browse the web in the app.

@jasekiw

This comment has been minimized.

jasekiw commented Apr 19, 2018

I just hit share on a song from the app and copied it right back in.

https://play.google.com/music/r/m/Tclrw7tcnfb6yo63op63f3rddoe?t=Vogue_-_Mia_Vaile

@jasekiw

This comment has been minimized.

jasekiw commented Apr 24, 2018

I found out why it wasn't working. It doesn't navigate if you are playing music. This isn't so obvious until you try it with music stopped. I assume this is to protected the user from wiping their playlist because it causes a full page reload.

Is there a way to control play music's navigation client side? Is there any information that can be gathered on this matter or is the player completely black boxed? Thanks!

@MarshallOfSound

This comment has been minimized.

Owner

MarshallOfSound commented Apr 26, 2018

I found out why it wasn't working. It doesn't navigate if you are playing music. This isn't so obvious until you try it with music stopped. I assume this is to protected the user from wiping their playlist because it causes a full page reload.

This makes sense now that I think about it, I guess the best thing to do is to assume the user knows what they are doing and just navigate 😆

@jasekiw

This comment has been minimized.

jasekiw commented Apr 29, 2018

@MarshallOfSound Is it possible to navigate the application on the client side? Play music navigates to a share link client side once the page is loaded. Is there any way to control google play music's router?

@ShowMeBillyJo

This comment has been minimized.

ShowMeBillyJo commented Aug 27, 2018

Is it possible to navigate the application on the client side? Play music navigates to a share link client side once the page is loaded. Is there any way to control google play music's router?

@MarshallOfSound: One thought I had about this is to navigate to the pasted URL in a separate process, wait for it to finish, and then capture the relevant hash. For example:

  1. Paste https://play.google.com/music/m/Tem7hx6faq5ldtpqjzhqh2ejjrq?t=Beauty_Beats_-_Beats_Antique
  2. Navigate and wait. The client-side URL eventually switches to https://play.google.com/music/listen?u=0#/album/Bl6po7brycpievzideeptcpccjy
  3. Replace the hash on the main UI with #/album/Bl6po7brycpievzideeptcpccjy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment