Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button in each player to switch service #3647

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

jostrander
Copy link
Collaborator

@jostrander jostrander commented Oct 20, 2019

Fixes #3627 and maybe others.

image

image

Copy link
Owner

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have absolute faith this works 😆

@MarshallOfSound MarshallOfSound merged commit 603bde2 into master Oct 29, 2019
@MarshallOfSound MarshallOfSound deleted the feature/switch-button branch October 29, 2019 04:22
@Sk8erOfBodom
Copy link

I'm sorry, but this is horrible, at the very least please make it another color so it's not a big red button invading my app. Even Google isn't advertising Youtube Music in their Google Play Music applications.
I think it doesn't even make sense that Youtube Music is in GPMDP.

If you don't change anything, I'll still love GPMDP but I might like you less. 😛

@Sk8erOfBodom
Copy link

Sk8erOfBodom commented Nov 22, 2019

Alright, I hid it myself with some CSS, but please still consider the issue, button with hard coded colors tarnishes one of the many great features of GPMDP!

@wakamex
Copy link

wakamex commented Dec 27, 2019

what if I click the button once and I can't go back. was this a trap all along? where the heck is this setting saved, I tried deleting all the files and reinstalling. using manual install of Build #3838 (rpm/x64) on clear linux. as per this post in issue #3545. it was working fine before i clicked the button. why did i have to click the button??
image

@jostrander
Copy link
Collaborator Author

jostrander commented Dec 27, 2019

@wakamex That looks like linux or mac, try using the tray icon if you have one to switch services.

Edit: Just saw you said linux, the config file is here: ~/.config/Google Play Music Desktop Player/json_store/.settings.json'

@wakamex
Copy link

wakamex commented Dec 27, 2019

thanks for the quick reply. that looks like the right file. changed "service": "youtube-music", to "service": "google-play-music", and restarted. looks the exact same. check the file again, and it's just reverted back to youtube-music. so doesn't seem to be reading that in as input, only saving its internal state? or maybe I need to modify it differently.
P.S. deleting the whole Google Play Music Desktop Player folder under .config did the trick. loads up like a fresh install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility of Youtube Music mode
4 participants