Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ytmusic.js #3922

Merged
merged 1 commit into from Mar 23, 2021
Merged

Bump ytmusic.js #3922

merged 1 commit into from Mar 23, 2021

Conversation

renatolond
Copy link
Contributor

This fixes gpmdp not detecting that a song is playing, #3920

@welcome
Copy link

welcome bot commented Mar 5, 2021

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run npm run lint locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
  • If you added new translation strings ensure that you have added empty strings for all languages
  • If you added new functionality or modified existing functionality please ensure it is tested

@cfsmp3
Copy link

cfsmp3 commented Mar 6, 2021

@renatolond it doesn't seem to fix the key problem for me though (linux)

@renatolond
Copy link
Contributor Author

@cfsmp3 seems to have solved it over here, I have multimedia keys and song titles back (arch linux here)

@aidan-24com
Copy link

I would love this to be merged in if it does indeed fix the media key issue. here's hoping

@francislavoie
Copy link

Are there any build artifacts I can grab for linux (.deb) so I can use this in the meantime? Don't really feel like trying to set up a build env 😬

@cfsmp3
Copy link

cfsmp3 commented Mar 10, 2021

Are there any build artifacts I can grab for linux (.deb) so I can use this in the meantime? Don't really feel like trying to set up a build env grimacing

Sure. It does not work for me but maybe I have a different problem on top of this.
the .deb is too large for GitHub so here you go:

https://drive.google.com/file/d/1w-DlXwhlbYdPhEJzLKxUHbKQmv4vfnJF/view?usp=sharing

@trobrock
Copy link

What does it take to get this merged? How can I help?

@jostrander jostrander merged commit b5c6bd8 into MarshallOfSound:master Mar 23, 2021
@welcome
Copy link

welcome bot commented Mar 23, 2021

Congrats on merging your first pull request! Have a ⭐

@trobrock
Copy link

Thanks @jostrander is the release process automated or does a new version need cut manually?

@jostrander
Copy link
Collaborator

The release process is very manual unfortunately and I have no access to the signing keys, so the repository owner will have to do a release, which tbh is unlikely to happen.

@trobrock
Copy link

@jostrander bummer.

@bruno-brant
Copy link

Hey @jostrander, why is it unlikely? Is @MarshallOfSound unfortunately too busy nowadays and no longer active in this project?

I'm grateful for all the work you guys have done here - GPMDP is a essential software to me and I would hate to see it fade away.

@Deloww
Copy link

Deloww commented May 14, 2022

This fixes gpmdp not detecting that a song is playing, #3920

1 similar comment
@Deloww
Copy link

Deloww commented May 14, 2022

This fixes gpmdp not detecting that a song is playing, #3920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants