Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for new session extension handling in Electron 9 #131

Merged
merged 1 commit into from Jun 27, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented May 22, 2020

Electron 9 deprecates the use of BrowserWindow extension handling so I implemented the new way for handling extensions.

See here:

@ghost ghost marked this pull request as draft May 22, 2020 09:55
@ghost ghost marked this pull request as ready for review May 22, 2020 12:57
@ghost ghost mentioned this pull request May 24, 2020
@inlet
Copy link

inlet commented May 29, 2020

The latest version of react devtools (v7.4.0) is not compatible with Electron 9.

I get this warning:

ExtensionLoadWarning: Warnings loading extension at 
/Users/pbrouwer/Library/Application Support/Google/Chrome
/Default/Extensions/fmkadmapgofadopljbjfkapdkoienihi/4.7.0_0: 
Unrecognized manifest key 'browser_action'. 
Unrecognized manifest key 'minimum_chrome_version'. 
Unrecognized manifest key 'update_url'. 
Manifest contains a differential_fingerprint key that will be overridden on extension update. 
Cannot load extension with file or directory name _metadata. 
Filenames starting with "_" are reserved for use by the system.

@kylewetton
Copy link

@inlet to confirm, is that a Redux DevTools issue or an issue with electron-devtools-installers way of installing it?

@inlet
Copy link

inlet commented Jun 5, 2020

@kylewetton it seems that electron 9 has changed loading of extensions. The issue is not this lib (sorry for commenting on this issue), it simply doesn't work if you do session.defaultSession.loadExtension with the React Devtools extension.

@byte47
Copy link

byte47 commented Jun 9, 2020

any update on this?

@reZach
Copy link

reZach commented Jun 10, 2020

@inlet Have you made an issue in the react devtools extension repo? I'm also interested in seeing this fixed.

@inlet
Copy link

inlet commented Jun 10, 2020

I’m not sure if this issue is React Devtools, Electron or even Chromium related,
See electron/electron#23662

@jakubzitny
Copy link

jakubzitny commented Jun 17, 2020

I also tried this PR, cloned repo and linked to my codebase. And React devtools do not work. The message I can see (probably related, not sure how much) is:

ExtensionLoadWarning: Warnings loading extension at /Users/user/Library/Application Support/Avocode/extensions/fmkadmapgofadopljbjfkapdkoienihi: Unrecognized manifest key 'browser_action'. Unrecognized manifest key 'minimum_chrome_version'. Unrecognized manifest key 'update_url'. Cannot load extension with file or directory name _metadata. Filenames starting with "_" are reserved for use by the system.

I am also loading the browser window via browserWindow.loadUrl("file://..."), same way as @develerik mentioned in #130 (comment).

Side note: We have immutable devtools (these need to be loaded in renderer) and that works. React devtools (need to be loaded from main process) do not work though.

If anyone can push mi in the right direction, I can help with this so we can merge and release this.

EIDT: I read more of the linked issues and realized it's probably not a bug in electron-devtools-installer

@sdc224
Copy link

sdc224 commented Jun 23, 2020

is it going to be available in the latest versions of electron-devtools-installer?

@MarshallOfSound MarshallOfSound changed the title Add support for new session extension handling in Electron 9 feat: add support for new session extension handling in Electron 9 Jun 27, 2020
@MarshallOfSound MarshallOfSound merged commit ab713a6 into MarshallOfSound:master Jun 27, 2020
@MarshallOfSound
Copy link
Owner

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants