From 93cae45b1ae051f64229325fb0c84435b54fa8b0 Mon Sep 17 00:00:00 2001 From: Marius Kittler Date: Fri, 31 Mar 2023 13:37:17 +0200 Subject: [PATCH] openqa-clone-job: Apply group settings to all cloned jobs This change makes `_GROUP` and `_GROUP_ID` "global" settings so one can clone a set of jobs into another group or no group via, e.g. `openqa-clone-job $some_url _GROUP=0`. Otherwise one needed to take dependencies into account and possibly specify `--parental-inheritance` (which would then apply all settings to the parent which might not be wanted as well). The downside is that leaving the parent jobs that are cloned as well in their job groups is not possible anymore. However, I don't think that this is a realy use case of our users anyways. --- lib/OpenQA/Script/CloneJob.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/OpenQA/Script/CloneJob.pm b/lib/OpenQA/Script/CloneJob.pm index 2e7670a82ff..bc2fbcb90d6 100644 --- a/lib/OpenQA/Script/CloneJob.pm +++ b/lib/OpenQA/Script/CloneJob.pm @@ -25,7 +25,7 @@ our @EXPORT = qw( post_jobs ); -use constant GLOBAL_SETTINGS => ('WORKER_CLASS'); +use constant GLOBAL_SETTINGS => (qw(WORKER_CLASS _GROUP _GROUP_ID)); use constant JOB_SETTING_OVERRIDES => { _GROUP => '_GROUP_ID',