From f4ddf8429a82f7f01dafd424d4f213e551baf5d6 Mon Sep 17 00:00:00 2001 From: wojciej <3244472+wojciej@users.noreply.github.com> Date: Tue, 19 Feb 2019 18:46:24 +0100 Subject: [PATCH] Fixing default base_topic to misensor based on implementation Hey, thanks for your great work - I have started using this branch and I very much like it. However I would like propose update of config.ini.dist: In config.ini.dist there is the following information: # The MQTT base topic to publish all Mi Flora sensor data topics under. # Default depends on the configured reporting_method #base_topic = miflora # Default for: mqtt-json, mqtt-smarthome #base_topic = homie # Default for: mqtt-homie #base_topic = homeassistant # Default for: homeassistant-mqtt #base_topic = v1/devices/me/telemetry # Default for: thingsboard-json #base_topic = # Default for: wirenboard-mqtt So as log as I use mqtt-json the default toppic should be miflora. While the default toppic is no longer **miflora** but **misensor** - what makes total sense cause we no longer use only miflora sensors - also it was already implemented in miflora-mqtt-daemon.py: if reporting_mode == 'mqtt-homie': default_base_topic = 'homie' elif reporting_mode == 'homeassistant-mqtt': default_base_topic = 'homeassistant' elif reporting_mode == 'thingsboard-json': default_base_topic = 'v1/devices/me/telemetry' elif reporting_mode == 'wirenboard-mqtt': default_base_topic = '' else: default_base_topic = 'misensor' Hope you dont mind my changes --- config.ini.dist | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config.ini.dist b/config.ini.dist index 7a5a7fd..db8e83d 100644 --- a/config.ini.dist +++ b/config.ini.dist @@ -50,7 +50,7 @@ # The MQTT base topic to publish all Mi Flora sensor data topics under. # Default depends on the configured reporting_method -#base_topic = miflora # Default for: mqtt-json, mqtt-smarthome +#base_topic = misensor # Default for: mqtt-json, mqtt-smarthome #base_topic = homie # Default for: mqtt-homie #base_topic = homeassistant # Default for: homeassistant-mqtt #base_topic = v1/devices/me/telemetry # Default for: thingsboard-json @@ -90,4 +90,4 @@ [MiTempBt] -# Add your Mi Temerature & Humidity sensors here. Setup is same as for [MiFlora] section \ No newline at end of file +# Add your Mi Temerature & Humidity sensors here. Setup is same as for [MiFlora] section