New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom docker image support #30

Merged
merged 1 commit into from Mar 16, 2018

Conversation

Projects
None yet
2 participants
@opyate
Contributor

opyate commented Jan 26, 2018

No description provided.

@opyate opyate referenced this pull request Jan 26, 2018

Closed

Ubuntu 17.04 reached EOL #29

@MartinSahlen

This comment has been minimized.

Owner

MartinSahlen commented Jan 26, 2018

Thanks! However, refering to #11, to you think it could be solved by using the docker python images?

@opyate

This comment has been minimized.

Contributor

opyate commented Jan 26, 2018

you think it could be solved by using the docker python images?

Yes, indeed :)

@opyate

This comment has been minimized.

Contributor

opyate commented Jan 26, 2018

In fact, the alt image is what I used to test this PR with - I built it out-of-band, then passed the new image name as an arg to the modified app.

@MartinSahlen

This comment has been minimized.

Owner

MartinSahlen commented Jan 26, 2018

Ah, my bad - I was a bit too quick. I will get this merged during the weekend! Might want to add some more fixes as well.

@MartinSahlen

This comment has been minimized.

Owner

MartinSahlen commented Mar 6, 2018

Hey @opyate , really sorry for letting this slip. Will get this in within end of week.

@MartinSahlen MartinSahlen merged commit 827d200 into MartinSahlen:master Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment