Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

make sure the dest folders exist #9

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

vicapow commented Mar 18, 2013

instead of silently failing

Owner

MartinodF commented Mar 21, 2013

Thanks for the PR!

I agree that this must be addressed. I'm not sure about silently creating the directory though.
I wouldn't want a module like this polluting my directory structure because of an error in its configuration.
Creating the proper destination directory is a one-time manual operation anyway...

Would logging an error and returning a 500 be ok with you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment