Skip to content

Add builder tech icon validation#201

Closed
Marve10s wants to merge 1 commit into
mainfrom
ibrahim/icon-ci-test
Closed

Add builder tech icon validation#201
Marve10s wants to merge 1 commit into
mainfrom
ibrahim/icon-ci-test

Conversation

@Marve10s
Copy link
Copy Markdown
Owner

Summary

  • add a builder tech icon validation script that checks rendered icon sources
  • run the icon validator in the existing lint CI job
  • fix current broken icon sources by using a valid Vue Simple Icons slug or removing unavailable icon mappings

Validation

  • bun run --filter=@better-fullstack/types build
  • bun run --filter=@better-fullstack/template-generator build
  • bun run --cwd apps/web validate:tech-icons
  • bun run --cwd apps/web typecheck
  • pre-commit lint hook completed successfully

@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
better-fullstack-web Ready Ready Preview, Comment May 23, 2026 5:29pm

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). labels May 23, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 54a52c3f13

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/cli/src/prompts/config-prompts.ts Outdated
Comment thread apps/cli/src/prompts/frontend.ts Outdated
@Marve10s Marve10s force-pushed the ibrahim/icon-ci-test branch from 54a52c3 to 33bcd0c Compare May 23, 2026 16:59
@github-actions github-actions Bot added size:L 100-499 effective changed lines (test files excluded in mixed PRs). and removed size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). labels May 23, 2026
@Marve10s Marve10s force-pushed the ibrahim/icon-ci-test branch from 33bcd0c to e91832a Compare May 23, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant