Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on mac. #28

Closed
wants to merge 1 commit into from
Closed

Conversation

zhongweiy
Copy link

fix issue #27

@MaskRay
Copy link
Owner

MaskRay commented Jul 9, 2018

ccls used to include <experimental/filesystem> which requires -lc++experimental. I have switched to LLVM/Support/FileSystem.h in commit f145c44

I just pushed some commits (transition from libclang indexer to clangIndex !!!) and removed such dependencies

@zhongweiy
Copy link
Author

Thanks! It seems we have less dependency now.

However, I've run into another building issue on current master:

/Users/john/projects/ccls/build/clang+llvm-6.0.0-x86_64-apple-darwin/bin/clang++  -DDEFAULT_RESOURCE_DIRECTORY=\"/Users/john/projects/ccls/build/clang+llvm-6.0.0-x86_64-apple-darwin/lib/clang/6.0.0\" -DLOGURU_FILENAME_WIDTH=18 -DLOGURU_THREADNAME_WIDTH=13 -DLOGURU_WITH_STREAMS=1 -I/Users/john/projects/ccls/src -I/Users/john/projects/ccls/third_party -I/Users/john/projects/ccls/third_party/rapidjson/include -isystem /Users/john/projects/ccls/build/clang+llvm-6.0.0-x86_64-apple-darwin/include  -O3 -DNDEBUG   -fno-rtti -Wall -Wno-sign-compare -nostdinc++ -cxx-isystem /Users/john/projects/ccls/build/clang+llvm-6.0.0-x86_64-apple-darwin/include/c++/v1 -std=c++1z -o CMakeFiles/ccls.dir/src/main.cc.o -c /Users/john/projects/ccls/src/main.cc
In file included from /Users/john/projects/ccls/src/main.cc:5:
/Users/john/projects/ccls/src/serializers/json.h:5:10: fatal error: 'rapidjson/document.h' file not found

It would be great if we have some CI checker to ensure the supported platform doesn't break.

@zhongweiy
Copy link
Author

The rapidjson/document.h error is caused by forgetting to run git submodule init. Sorry for any inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants