Workaround inconsistency in intersection between ranges. #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly there is some confusion about ranges in the LSP protocol. It turns out that VS code, when requesting code actions, sends range s,e in the request, with the associated meaning that e is _included_ in the range, i.e. the interval is [s,e]. The emacs lsp-mode also uses this convention. However, the protocl specifies that the end in the range s,e should not be part of the interval, i.e. s,e is supposed to correspond to [s,e[: https://microsoft.github.io/language-server-protocol/specifications/specification-3-17/#range This was brought up with emacs-lsp, where the maintainer stated that he prefers to stay compatbile with VS code rather than the protocol, and that the protocol should likely be amended: emacs-lsp/lsp-mode#3144 If that is the case, ccls intersection between ranges should be amended for now, such that the end parameter is part of the range.
|
Fixes #838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly there is some confusion about ranges in the LSP protocol. It turns out
that VS code, when requesting code actions, sends range s,e in the request,
with the associated meaning that e is included in the range, i.e. the interval
is [s,e]. The emacs lsp-mode also uses this convention.
However, the protocl specifies that the end in the range s,e should not be part
of the interval, i.e. s,e is supposed to correspond to [s,e[:
https://microsoft.github.io/language-server-protocol/specifications/specification-3-17/#range
This was brought up with emacs-lsp, where the maintainer stated that he prefers
to stay compatbile with VS code rather than the protocol, and that the protocol
should likely be amended:
emacs-lsp/lsp-mode#3144
If that is the case, ccls intersection between ranges should be amended for now,
such that the end parameter is part of the range.