Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current value of rotation radius if available #484

Conversation

blurfl
Copy link
Collaborator

@blurfl blurfl commented Dec 1, 2017

Trying to do the calibration step with a top-pantograph linkage (129mm rotationradius), I find that choosing the Triangular calibration writes 260 to rotationradius in groundcontrol.ini overwriting the previous value. This PR looks for the current value and uses that if it is found.

Bring my fork up to date with MaslowCNC/GroundControl-master.
Trying to do the calibration step with a top-pantograph linkage (129mm rotationradius), I find that choosing the Triangular calibration writes 260 to rotationradius in groundcontrol.ini overwriting the previous value. This PR looks for the current value and uses that if it is found.
#Get the value if it's already there...
rotationRadius = self.data.config.get('Advanced Settings', 'rotationRadius')
print "Rotation radius is " + str(rotationRadius)
except:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good planning ahead for if the option does not exist

@BarbourSmith BarbourSmith merged commit be62a39 into MaslowCNC:master Dec 1, 2017
@blurfl blurfl deleted the Use-current-value-of-rotationRadius-if-available branch December 22, 2017 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants