Schema: Add foreign key constraints

[Marlysson]

Indexes: Create/Drop foreign indexes by name

• Add a new index named as linked tables[1]
• Drop indexes [2]

Constraints: Create/Drop indexes by name

• Create a foreign index indicating the linked tables[3]
• Drop foreign index [2]

References:

[1] https://orator-orm.com/docs/0.9/schema_builder.html#adding-indexes
[2] https://orator-orm.com/docs/0.9/schema_builder.html#dropping-indexes
[3] https://orator-orm.com/docs/0.9/schema_builder.html#foreign-keys

[Marlysson]

@josephmancuso Does our unsigned method will have the different signature from others orms?

Instead:

blueprint.integer('some_value').unsigned()

Will be, right ?

blueprint.unsigned('some_value')
blueprint.unsigned_integer('some_value')

[josephmancuso]

@Marlysson I think both

[josephmancuso]

These 2 ways:

blueprint.integer('some_value').unsigned()
blueprint.unsigned_integer('some_value')

[Marlysson]

@josephmancuso I've tried abstract the relations with some way but just came in my mind use of dictionary haha, do you have some other way?[1] For now, are working, now I will implement BaseGrammar to handle these relations and test the complete constraint.

[1] I started developing one class called ForeignKeyRelation but it just has 3 attributes and nothing more. I avoided this idea.

class ForeignKeyRelation:

    # init method

    def foreign(self, local_column=None):
        self.local_column = local_column

    def references(self, external_column=None):
        self.external_column = external_column

    def on(self, table=None):
        self.foreign_table = table

[2] I think the use of constraint_type = "foreign_key" is too necessary ( to match with method constraint ), but I don't see where to put it on workflow.

[josephmancuso]

You'll need a test that looks like this:

    def test_sets_foreign_constraint(self):
        with self.schema.create('users') as table:
             table.string('name')
             table.integer('profile_id')

             table.foreign('profile_id').references('user').on('users')

        sql = getattr(
            self, inspect.currentframe().f_code.co_name.replace("test_", "")
        )()
        self.assertEqual(to_sql, sql)

and then make the child test like this:

def sets_foreign_constraint(self):
     return (
        "CREATE TABLE `users` ("
            "`name` VARCHAR(255) NOT NULL, "
            "`profile_id` INT UNSIGNED,  "
                "INDEX profile_users_profile_id, "
                "FOREIGN KEY (`profile_id`)"
                "REFERENCES `profile`(`id`)"
        ")"
    )

[Marlysson]

Ok, After that, I remove the exceptions that ensure fields are filled?
I will change the tests to this.

[josephmancuso]

This definition looks wrong. It should only accept a column name:

table.foreign('profile_id').references('profile').on('id')

[Marlysson]

Ok. I did put *args because of this statement:

FOREIGN KEY (product_category, product_id)
      REFERENCES product(category, id)

Referencing two columns in the same constraint.

[Marlysson]

Here the reference: https://dev.mysql.com/doc/refman/8.0/en/create-table-foreign-keys.html#foreign-key-restrictions

The columns and table aren't quoted with `, I found it strange.

[josephmancuso]

Is there a checkbox for you on the right side where it says something like "allow commits from repo owner"?

[josephmancuso]

I'd like to work on this with you but by default idt I can push to this pull request

[Marlysson]

It's checked, but with a different message.

[Marlysson]

@corentinalcoy @josephmancuso
Does here is just add a *args to receive more than one column?

[ghost]

No wait, Joe is looking the way the schema module is done. I think we have a problem...

[josephmancuso]

Closing in favor of #77