Skip to content

Commit

Permalink
X.L.Maximize: Make layout forget maximized window when it is closed
Browse files Browse the repository at this point in the history
The X.L.Maximize layout modifier does not track whether the window it stores as
maximized does still exist.  The X server reuses window IDs.  As a result, I
was able to reproduce the following behaviour (e.g., by opening and closing
xpdf windows): Create a window, maximize it, close it without restoring it to
its normal state.  Open a new window with the same window ID (e.g., an xpdf
window after just closing an xpdf window).  The new window will open maximized,
which is not what one would expect.  This patch addresses this problem,
removing the ID of the maximized window from the layout when the maximized
window is closed.
  • Loading branch information
nzeh committed Oct 29, 2010
1 parent e8de1b1 commit dcfd49b
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion XMonad/Layout/Maximize.hs
Expand Up @@ -64,12 +64,14 @@ instance LayoutModifier Maximize Window where
pureModifier (Maximize (Just target)) rect (Just (S.Stack focused _ _)) wrs =
if focused == target
then (maxed ++ rest, Nothing)
else (rest ++ maxed, Nothing)
else (rest ++ maxed, lay)
where
(toMax, rest) = partition (\(w, _) -> w == target) wrs
maxed = map (\(w, _) -> (w, maxRect)) toMax
maxRect = Rectangle (rect_x rect + 25) (rect_y rect + 25)
(rect_width rect - 50) (rect_height rect - 50)
lay | null maxed = Just (Maximize Nothing)
| otherwise = Nothing
pureModifier _ _ _ wrs = (wrs, Nothing)

pureMess (Maximize mw) m = case fromMessage m of
Expand Down

0 comments on commit dcfd49b

Please sign in to comment.