New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java.lang.AssertionError #30

Closed
phyre opened this Issue Aug 14, 2013 · 28 comments

Comments

Projects
None yet
8 participants
@phyre

phyre commented Aug 14, 2013

Hia. Im trying to run this on my forge server and I get this

23:30:30 [WARNING] [mcore] Task #4 for mcore v6.5.2 generated an exception
java.lang.AssertionError
at com.massivecraft.mcore.xlib.gson.internal.bind.TypeAdapters$EnumTypeAdapter.(TypeAdapters.java:686)
at com.massivecraft.mcore.xlib.gson.internal.bind.TypeAdapters$24.create(TypeAdapters.java:715)
at com.massivecraft.mcore.xlib.gson.Gson.getAdapter(Gson.java:371)
at com.massivecraft.mcore.xlib.gson.internal.bind.MapTypeAdapterFactory.getKeyAdapter(MapTypeAdapterFactory.java:147)
at com.massivecraft.mcore.xlib.gson.internal.bind.MapTypeAdapterFactory.create(MapTypeAdapterFactory.java:130)
at com.massivecraft.mcore.xlib.gson.Gson.getAdapter(Gson.java:371)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory$1.(ReflectiveTypeAdapterFactory.java:85)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory.createBoundField(ReflectiveTypeAdapterFactory.java:84)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory.getBoundFields(ReflectiveTypeAdapterFactory.java:121)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory.create(ReflectiveTypeAdapterFactory.java:75)
at com.massivecraft.mcore.xlib.gson.Gson.getAdapter(Gson.java:371)
at com.massivecraft.mcore.xlib.gson.Gson.toJson(Gson.java:556)
at com.massivecraft.mcore.xlib.gson.Gson.toJsonTree(Gson.java:457)
at com.massivecraft.mcore.store.Coll.saveToRemote(Coll.java:478)
at com.massivecraft.mcore.store.Coll.syncId(Coll.java:616)
at com.massivecraft.mcore.store.Coll.syncSuspects(Coll.java:661)
at com.massivecraft.mcore.store.Coll.onTick(Coll.java:711)
at com.massivecraft.mcore.MCore$1.run(MCore.java:108)
at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftTask.run(CraftTask.java:58)
at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:784)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:318)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:741)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:625)
at net.minecraft.server.ThreadMinecraftServer.run(ThreadMinecraftServer.java:16)

Thanks in advance for any help

@phyre phyre closed this Aug 15, 2013

@phyre phyre reopened this Aug 16, 2013

@phyre

This comment has been minimized.

Show comment
Hide comment
@phyre

phyre Aug 16, 2013

sorry, I didn't mean to close it.

phyre commented Aug 16, 2013

sorry, I didn't mean to close it.

@Solarity

This comment has been minimized.

Show comment
Hide comment
@Solarity

Solarity Aug 16, 2013

Hey dude=) I have the same problem on my server,
The server is stable though.
I am just wondering why I get this error and what it does/means (because I don't have problems ingame with any mod/plugin)
I am using MCPC+ Latest build.

Error message: Same as the above, Only I'm using Mcore's Latest version "V6.6.0"

Solarity commented Aug 16, 2013

Hey dude=) I have the same problem on my server,
The server is stable though.
I am just wondering why I get this error and what it does/means (because I don't have problems ingame with any mod/plugin)
I am using MCPC+ Latest build.

Error message: Same as the above, Only I'm using Mcore's Latest version "V6.6.0"

@phyre

This comment has been minimized.

Show comment
Hide comment
@phyre

phyre Aug 16, 2013

Unfortunately for me it causes my server to crash. I removed it and the server is fine. I'm also using the latest mcpc build. I also have lwc on ther server, and when mcore was loaded, I was getting spammed in the console with errors when people were placing protected chests or anything lwc protected. But, like I said, I removed it and everything works like a charm. It's unfortunate though, because mcore is necessary for creative gates :(

Sent from my iPad

On Aug 16, 2013, at 11:18, Solarity notifications@github.com wrote:

Hey dude=) I have the same problem on my server,
The server is stable though.
I am just wondering why I get this error and what it does/means (because I don't have problems ingame with any mod/plugin)
I am using MCPC+ Latest build.

Error message: Same as the above, Only I'm using Mcore's Latest version "V6.6.0"


Reply to this email directly or view it on GitHub.

phyre commented Aug 16, 2013

Unfortunately for me it causes my server to crash. I removed it and the server is fine. I'm also using the latest mcpc build. I also have lwc on ther server, and when mcore was loaded, I was getting spammed in the console with errors when people were placing protected chests or anything lwc protected. But, like I said, I removed it and everything works like a charm. It's unfortunate though, because mcore is necessary for creative gates :(

Sent from my iPad

On Aug 16, 2013, at 11:18, Solarity notifications@github.com wrote:

Hey dude=) I have the same problem on my server,
The server is stable though.
I am just wondering why I get this error and what it does/means (because I don't have problems ingame with any mod/plugin)
I am using MCPC+ Latest build.

Error message: Same as the above, Only I'm using Mcore's Latest version "V6.6.0"


Reply to this email directly or view it on GitHub.

@Solarity

This comment has been minimized.

Show comment
Hide comment
@Solarity

Solarity Aug 16, 2013

Awh sorry to hear that :C what is LWC?, and Mcore allso supports Factions which is great,
Maybe I can help you I have some knowledge about removing bugs ;p

Solarity commented Aug 16, 2013

Awh sorry to hear that :C what is LWC?, and Mcore allso supports Factions which is great,
Maybe I can help you I have some knowledge about removing bugs ;p

@phyre

This comment has been minimized.

Show comment
Hide comment
@phyre

phyre Sep 1, 2013

15:45:17 [WARNING] [mcore] Task #4 for mcore v6.7.0 generated an exception
java.lang.AssertionError
at com.massivecraft.mcore.xlib.gson.internal.bind.TypeAdapters$EnumTypeAdapter.(TypeAdapters.java:686)
at com.massivecraft.mcore.xlib.gson.internal.bind.TypeAdapters$24.create(TypeAdapters.java:715)
at com.massivecraft.mcore.xlib.gson.Gson.getAdapter(Gson.java:371)
at com.massivecraft.mcore.xlib.gson.internal.bind.MapTypeAdapterFactory.getKeyAdapter(MapTypeAdapterFactory.java:147)
at com.massivecraft.mcore.xlib.gson.internal.bind.MapTypeAdapterFactory.create(MapTypeAdapterFactory.java:130)
at com.massivecraft.mcore.xlib.gson.Gson.getAdapter(Gson.java:371)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory$1.(ReflectiveTypeAdapterFactory.java:85)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory.createBoundField(ReflectiveTypeAdapterFactory.java:84)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory.getBoundFields(ReflectiveTypeAdapterFactory.java:121)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory.create(ReflectiveTypeAdapterFactory.java:75)
at com.massivecraft.mcore.xlib.gson.Gson.getAdapter(Gson.java:371)
at com.massivecraft.mcore.xlib.gson.Gson.toJson(Gson.java:556)
at com.massivecraft.mcore.xlib.gson.Gson.toJsonTree(Gson.java:457)
at com.massivecraft.mcore.store.Coll.saveToRemote(Coll.java:480)
at com.massivecraft.mcore.store.Coll.syncId(Coll.java:630)
at com.massivecraft.mcore.store.Coll.syncSuspects(Coll.java:675)
at com.massivecraft.mcore.store.Coll.onTick(Coll.java:725)
at com.massivecraft.mcore.MCore$1.run(MCore.java:108)
at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftTask.run(CraftTask.java:58)
at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:784)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:318)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:741)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:625)
at net.minecraft.server.ThreadMinecraftServer.run(ThreadMinecraftServer.java:16)

Updated to the new versions. Getting this error, and creative gates won't generate a config.

phyre commented Sep 1, 2013

15:45:17 [WARNING] [mcore] Task #4 for mcore v6.7.0 generated an exception
java.lang.AssertionError
at com.massivecraft.mcore.xlib.gson.internal.bind.TypeAdapters$EnumTypeAdapter.(TypeAdapters.java:686)
at com.massivecraft.mcore.xlib.gson.internal.bind.TypeAdapters$24.create(TypeAdapters.java:715)
at com.massivecraft.mcore.xlib.gson.Gson.getAdapter(Gson.java:371)
at com.massivecraft.mcore.xlib.gson.internal.bind.MapTypeAdapterFactory.getKeyAdapter(MapTypeAdapterFactory.java:147)
at com.massivecraft.mcore.xlib.gson.internal.bind.MapTypeAdapterFactory.create(MapTypeAdapterFactory.java:130)
at com.massivecraft.mcore.xlib.gson.Gson.getAdapter(Gson.java:371)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory$1.(ReflectiveTypeAdapterFactory.java:85)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory.createBoundField(ReflectiveTypeAdapterFactory.java:84)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory.getBoundFields(ReflectiveTypeAdapterFactory.java:121)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory.create(ReflectiveTypeAdapterFactory.java:75)
at com.massivecraft.mcore.xlib.gson.Gson.getAdapter(Gson.java:371)
at com.massivecraft.mcore.xlib.gson.Gson.toJson(Gson.java:556)
at com.massivecraft.mcore.xlib.gson.Gson.toJsonTree(Gson.java:457)
at com.massivecraft.mcore.store.Coll.saveToRemote(Coll.java:480)
at com.massivecraft.mcore.store.Coll.syncId(Coll.java:630)
at com.massivecraft.mcore.store.Coll.syncSuspects(Coll.java:675)
at com.massivecraft.mcore.store.Coll.onTick(Coll.java:725)
at com.massivecraft.mcore.MCore$1.run(MCore.java:108)
at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftTask.run(CraftTask.java:58)
at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:784)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:318)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:741)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:625)
at net.minecraft.server.ThreadMinecraftServer.run(ThreadMinecraftServer.java:16)

Updated to the new versions. Getting this error, and creative gates won't generate a config.

@iamnessy2

This comment has been minimized.

Show comment
Hide comment
@iamnessy2

iamnessy2 Sep 18, 2013

mcpc is very incompatible with many plugins and probably won't be supported by most plugins just saying.

iamnessy2 commented Sep 18, 2013

mcpc is very incompatible with many plugins and probably won't be supported by most plugins just saying.

@phyre

This comment has been minimized.

Show comment
Hide comment
@phyre

phyre Sep 18, 2013

Every other plugin that I wanted to use, works. The only one I have had an issue with is mcore. The only reason I wanted it was for creative gates. I have found another portal plugin that suits my needs, and have long since abandoned attempting to use this. It's a shame, this and creative gates are damn nice plugins.

Also, if you take the time to read the responses, it does work with MCPC+, as Solarity pointed out.

Additionally, I do understand that the writers of plugins such as these do them for free, and in their spare time. So, to whomever it is that created this and those that depend on mcore, Thank you for your work and effort. I would love to see some compatibility with MCPC+ servers. But, I'm happy that it at least works on my non modded server.

phyre commented Sep 18, 2013

Every other plugin that I wanted to use, works. The only one I have had an issue with is mcore. The only reason I wanted it was for creative gates. I have found another portal plugin that suits my needs, and have long since abandoned attempting to use this. It's a shame, this and creative gates are damn nice plugins.

Also, if you take the time to read the responses, it does work with MCPC+, as Solarity pointed out.

Additionally, I do understand that the writers of plugins such as these do them for free, and in their spare time. So, to whomever it is that created this and those that depend on mcore, Thank you for your work and effort. I would love to see some compatibility with MCPC+ servers. But, I'm happy that it at least works on my non modded server.

@oloflarsson

This comment has been minimized.

Show comment
Hide comment
@oloflarsson

oloflarsson Sep 18, 2013

Member

This issue is originating from the serialization library GSON:
https://github.com/MassiveCraft/mcore/blob/91f9ec7c0c7d9a11a35db905be520f5cf6b6743e/src/com/massivecraft/mcore/xlib/gson/internal/bind/TypeAdapters.java#L686

It seems MCPC is making use of "corrupt" enums?

Member

oloflarsson commented Sep 18, 2013

This issue is originating from the serialization library GSON:
https://github.com/MassiveCraft/mcore/blob/91f9ec7c0c7d9a11a35db905be520f5cf6b6743e/src/com/massivecraft/mcore/xlib/gson/internal/bind/TypeAdapters.java#L686

It seems MCPC is making use of "corrupt" enums?

@md-5

This comment has been minimized.

Show comment
Hide comment
@md-5

md-5 Sep 18, 2013

Almost certainly a result of Proguard obfuscation rules being too strict

md-5 commented Sep 18, 2013

Almost certainly a result of Proguard obfuscation rules being too strict

@cdkrot

This comment has been minimized.

Show comment
Hide comment
@cdkrot

cdkrot Oct 6, 2013

oloflarsson,

This issue is originating from the serialization library GSON
You are having a Gson library in com.massivecraft.*** package.
Why not using a common minecraft gson library in com.google.gson package,
Excluded from forge transformation?

cdkrot commented Oct 6, 2013

oloflarsson,

This issue is originating from the serialization library GSON
You are having a Gson library in com.massivecraft.*** package.
Why not using a common minecraft gson library in com.google.gson package,
Excluded from forge transformation?

@oloflarsson

This comment has been minimized.

Show comment
Hide comment
@oloflarsson

oloflarsson Oct 6, 2013

Member

@cdkrot - I dunno actually. There was a reason a while back but I'm not sure I remember anymore. Anyhow this is not my issue. If mcpc+ breaks external libraries that is not my fault in any way.

Member

oloflarsson commented Oct 6, 2013

@cdkrot - I dunno actually. There was a reason a while back but I'm not sure I remember anymore. Anyhow this is not my issue. If mcpc+ breaks external libraries that is not my fault in any way.

@cdkrot

This comment has been minimized.

Show comment
Hide comment
@cdkrot

cdkrot Oct 10, 2013

Yes.
Fortunately forge tweaker class allows cascaded tweaks. (can add exclusions)
https://github.com/MinecraftPortCentral/FML/blob/master/common/cpw/mods/fml/common/launcher/FMLTweaker.java

cdkrot commented Oct 10, 2013

Yes.
Fortunately forge tweaker class allows cascaded tweaks. (can add exclusions)
https://github.com/MinecraftPortCentral/FML/blob/master/common/cpw/mods/fml/common/launcher/FMLTweaker.java

@cdkrot

This comment has been minimized.

Show comment
Hide comment
@cdkrot

cdkrot Oct 10, 2013

@oloflarsson
|My gson library is in the package "com.massivecraft.mcore.xlib.gson". Feel free to exclude the whole
|"com.massivecraft.mcore.xlib" package yet I'm not sure this is going to fix the ticket either.

@cdkrot
|Yes.
|Fortunately forge tweaker class allows cascaded tweaks. (can add exclusions)
|https://github.com/MinecraftPortCentral/FML/blob/master/common/cpw/mods/fml/common/launcher/FMLTweaker.java

Performed tests launching with cascaded tweaks and excluding your packages.
Nether excluding of "com.massivecraft.mcore.xlib."; "com.massivecraft.mcore."; "com.massivecraft." fixed the problem. Still getting java.lang.AssertionException; StackTrace looks the same.

cdkrot commented Oct 10, 2013

@oloflarsson
|My gson library is in the package "com.massivecraft.mcore.xlib.gson". Feel free to exclude the whole
|"com.massivecraft.mcore.xlib" package yet I'm not sure this is going to fix the ticket either.

@cdkrot
|Yes.
|Fortunately forge tweaker class allows cascaded tweaks. (can add exclusions)
|https://github.com/MinecraftPortCentral/FML/blob/master/common/cpw/mods/fml/common/launcher/FMLTweaker.java

Performed tests launching with cascaded tweaks and excluding your packages.
Nether excluding of "com.massivecraft.mcore.xlib."; "com.massivecraft.mcore."; "com.massivecraft." fixed the problem. Still getting java.lang.AssertionException; StackTrace looks the same.

@cdkrot

This comment has been minimized.

Show comment
Hide comment
@cdkrot

cdkrot Oct 10, 2013

Stack trace in case it may be useful:
2013-10-10 21:48:48 [WARNING] [mcore] Task #4 for mcore v6.7.0 generated an exception
java.lang.AssertionError
at com.massivecraft.mcore.xlib.gson.internal.bind.TypeAdapters$EnumTypeAdapter.(TypeAdapters.java:686)
at com.massivecraft.mcore.xlib.gson.internal.bind.TypeAdapters$24.create(TypeAdapters.java:715)
at com.massivecraft.mcore.xlib.gson.Gson.getAdapter(Gson.java:371)
at com.massivecraft.mcore.xlib.gson.internal.bind.CollectionTypeAdapterFactory.create(CollectionTypeAdapterFactory.java:54)
at com.massivecraft.mcore.xlib.gson.Gson.getAdapter(Gson.java:371)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory$1.(ReflectiveTypeAdapterFactory.java:85)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory.createBoundField(ReflectiveTypeAdapterFactory.java:84)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory.getBoundFields(ReflectiveTypeAdapterFactory.java:121)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory.create(ReflectiveTypeAdapterFactory.java:75)
at com.massivecraft.mcore.xlib.gson.Gson.getAdapter(Gson.java:371)
at com.massivecraft.mcore.xlib.gson.Gson.toJson(Gson.java:556)
at com.massivecraft.mcore.xlib.gson.Gson.toJsonTree(Gson.java:457)
at com.massivecraft.mcore.store.Coll.saveToRemote(Coll.java:480)
at com.massivecraft.mcore.store.Coll.syncId(Coll.java:630)
at com.massivecraft.mcore.store.Coll.syncSuspects(Coll.java:675)
at com.massivecraft.mcore.store.Coll.onTick(Coll.java:725)
at com.massivecraft.mcore.MCore$1.run(MCore.java:108)
at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftTask.run(CraftTask.java:58)
at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:800)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:327)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:757)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:641)
at net.minecraft.server.ThreadMinecraftServer.run(ThreadMinecraftServer.java:16)

cdkrot commented Oct 10, 2013

Stack trace in case it may be useful:
2013-10-10 21:48:48 [WARNING] [mcore] Task #4 for mcore v6.7.0 generated an exception
java.lang.AssertionError
at com.massivecraft.mcore.xlib.gson.internal.bind.TypeAdapters$EnumTypeAdapter.(TypeAdapters.java:686)
at com.massivecraft.mcore.xlib.gson.internal.bind.TypeAdapters$24.create(TypeAdapters.java:715)
at com.massivecraft.mcore.xlib.gson.Gson.getAdapter(Gson.java:371)
at com.massivecraft.mcore.xlib.gson.internal.bind.CollectionTypeAdapterFactory.create(CollectionTypeAdapterFactory.java:54)
at com.massivecraft.mcore.xlib.gson.Gson.getAdapter(Gson.java:371)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory$1.(ReflectiveTypeAdapterFactory.java:85)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory.createBoundField(ReflectiveTypeAdapterFactory.java:84)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory.getBoundFields(ReflectiveTypeAdapterFactory.java:121)
at com.massivecraft.mcore.xlib.gson.internal.bind.ReflectiveTypeAdapterFactory.create(ReflectiveTypeAdapterFactory.java:75)
at com.massivecraft.mcore.xlib.gson.Gson.getAdapter(Gson.java:371)
at com.massivecraft.mcore.xlib.gson.Gson.toJson(Gson.java:556)
at com.massivecraft.mcore.xlib.gson.Gson.toJsonTree(Gson.java:457)
at com.massivecraft.mcore.store.Coll.saveToRemote(Coll.java:480)
at com.massivecraft.mcore.store.Coll.syncId(Coll.java:630)
at com.massivecraft.mcore.store.Coll.syncSuspects(Coll.java:675)
at com.massivecraft.mcore.store.Coll.onTick(Coll.java:725)
at com.massivecraft.mcore.MCore$1.run(MCore.java:108)
at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftTask.run(CraftTask.java:58)
at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:800)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:327)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:757)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:641)
at net.minecraft.server.ThreadMinecraftServer.run(ThreadMinecraftServer.java:16)

@OniBait

This comment has been minimized.

Show comment
Hide comment
@OniBait

OniBait Oct 23, 2013

Contributor

Finally got around to looking at this -- looks like the problem here is that you are throwing an AssertionError if you can't find the field in the enumeration -- the issue here is that with Forge, enumerations will be modified (hacky, but allowed in Java) but AFAIK, you can't add a Field to a class after it has been loaded (before it has been loaded, fine... but not after).

Since you are specifically looking for annotations in that call, and we won't have any annotation, why not just swallow the exception and continue on?

Contributor

OniBait commented Oct 23, 2013

Finally got around to looking at this -- looks like the problem here is that you are throwing an AssertionError if you can't find the field in the enumeration -- the issue here is that with Forge, enumerations will be modified (hacky, but allowed in Java) but AFAIK, you can't add a Field to a class after it has been loaded (before it has been loaded, fine... but not after).

Since you are specifically looking for annotations in that call, and we won't have any annotation, why not just swallow the exception and continue on?

@oloflarsson

This comment has been minimized.

Show comment
Hide comment
@oloflarsson

oloflarsson Oct 25, 2013

Member

@OniBait - Just to clearify it's not really I that's throwning an AssertionError - The GSON library is. I'm not sure the correct solution is creating an inhouse version of GSON. Perhaps you could improve upon your hacky method somehow? Can I just swallow the exception an continue on? Probably not. GSON serialization will fail.

Member

oloflarsson commented Oct 25, 2013

@OniBait - Just to clearify it's not really I that's throwning an AssertionError - The GSON library is. I'm not sure the correct solution is creating an inhouse version of GSON. Perhaps you could improve upon your hacky method somehow? Can I just swallow the exception an continue on? Probably not. GSON serialization will fail.

@OniBait

This comment has been minimized.

Show comment
Hide comment
@OniBait

OniBait Oct 26, 2013

Contributor

@oloflarsson Let me revisit it then. I may be making some wrong assumptions about what is going on and I should probably just build and run through the debugger and see wtf is going on.

Contributor

OniBait commented Oct 26, 2013

@oloflarsson Let me revisit it then. I may be making some wrong assumptions about what is going on and I should probably just build and run through the debugger and see wtf is going on.

@OniBait

This comment has been minimized.

Show comment
Hide comment
@OniBait

OniBait Oct 26, 2013

Contributor

@oloflarsson Also -- GSON is included w/ CraftBukkit iirc, so might make more sense to use that version.

Contributor

OniBait commented Oct 26, 2013

@oloflarsson Also -- GSON is included w/ CraftBukkit iirc, so might make more sense to use that version.

@oloflarsson

This comment has been minimized.

Show comment
Hide comment
@oloflarsson

oloflarsson Oct 26, 2013

Member

Yeah I know GSON is included in CraftBukkit but I find using my own embedded copy more useful. It's easier to find errors that way. This link would not have been possible otherwise: https://github.com/MassiveCraft/mcore/blob/91f9ec7c0c7d9a11a35db905be520f5cf6b6743e/src/com/massivecraft/mcore/xlib/gson/internal/bind/TypeAdapters.java#L686

Member

oloflarsson commented Oct 26, 2013

Yeah I know GSON is included in CraftBukkit but I find using my own embedded copy more useful. It's easier to find errors that way. This link would not have been possible otherwise: https://github.com/MassiveCraft/mcore/blob/91f9ec7c0c7d9a11a35db905be520f5cf6b6743e/src/com/massivecraft/mcore/xlib/gson/internal/bind/TypeAdapters.java#L686

@oloflarsson

This comment has been minimized.

Show comment
Hide comment
Member

oloflarsson commented Oct 26, 2013

@dunem666

This comment has been minimized.

Show comment
Hide comment
@dunem666

dunem666 Nov 12, 2013

so any updates on this? this is causing factions to fail on MCPC+ servers thus servers are closed!

dunem666 commented Nov 12, 2013

so any updates on this? this is causing factions to fail on MCPC+ servers thus servers are closed!

@oloflarsson

This comment has been minimized.

Show comment
Hide comment
@oloflarsson

oloflarsson Nov 12, 2013

Member

@dunem666, this has nothing to do with mcore. The issue is fully on the MCPC+ side of things. Create a new issue there would you?

Member

oloflarsson commented Nov 12, 2013

@dunem666, this has nothing to do with mcore. The issue is fully on the MCPC+ side of things. Create a new issue there would you?

@dunem666

This comment has been minimized.

Show comment
Hide comment
@dunem666

dunem666 Nov 12, 2013

oh, well they sent me here and blamed you :p

dunem666 commented Nov 12, 2013

oh, well they sent me here and blamed you :p

@oloflarsson

This comment has been minimized.

Show comment
Hide comment
@oloflarsson

oloflarsson Nov 12, 2013

Member

@dunem666, No really. The issue only occurs with MCPC+ and not with CraftBukkit or Spigot. Thus the fault is on the MCPC+ side of things.

Member

oloflarsson commented Nov 12, 2013

@dunem666, No really. The issue only occurs with MCPC+ and not with CraftBukkit or Spigot. Thus the fault is on the MCPC+ side of things.

@iamnessy2

This comment has been minimized.

Show comment
Hide comment
@iamnessy2

iamnessy2 Nov 12, 2013

Very true ^^

iamnessy2 commented Nov 12, 2013

Very true ^^

@OniBait

This comment has been minimized.

Show comment
Hide comment
@OniBait

OniBait Nov 13, 2013

Contributor

Uhm.. wut? I didn't blame MCore, nor did we send you here? I closed your issue because it was a duplicate of another one that is still open.

Contributor

OniBait commented Nov 13, 2013

Uhm.. wut? I didn't blame MCore, nor did we send you here? I closed your issue because it was a duplicate of another one that is still open.

@OniBait

This comment has been minimized.

Show comment
Hide comment
@OniBait

OniBait Nov 13, 2013

Contributor

Sent you a PR on this @oloflarsson - it is what I thought it was here: #30 (comment) and had both @md-5 and LexManos agree with me as to the root cause when talking w/ them on IRC.

Sorry to ask you to fix it on your end. If I could fix it on the MCPC+ side, that'd be my preference, but Java is a bit picky about what it lets you modify at runtime.

Contributor

OniBait commented Nov 13, 2013

Sent you a PR on this @oloflarsson - it is what I thought it was here: #30 (comment) and had both @md-5 and LexManos agree with me as to the root cause when talking w/ them on IRC.

Sorry to ask you to fix it on your end. If I could fix it on the MCPC+ side, that'd be my preference, but Java is a bit picky about what it lets you modify at runtime.

@oloflarsson

This comment has been minimized.

Show comment
Hide comment
@oloflarsson

oloflarsson Nov 13, 2013

Member

@OniBait - Thanks a lot. That pull request makes a lot of sense.

Member

oloflarsson commented Nov 13, 2013

@OniBait - Thanks a lot. That pull request makes a lot of sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment