VCS-74: Add +build tags to tests, to enable selective per-VCS testing #75
Conversation
|
✅ Build vcs build-35.master completed (commit 0a6c7bf8e5 by @m0j0hn) |
git.go
Outdated
| s.log(out) | ||
| if err != nil { | ||
| return NewLocalError("Error while updating submodule sources", err, string(out)) | ||
| } |
There was a problem hiding this comment.
Did you mean to include this change as part of this PR?
There was a problem hiding this comment.
Nope. Good catch!
Just pushed new revision without that -
please take another look when you get a chance -
and Thanks!
|
✅ Build vcs build-36.master completed (commit 4d2cf7dcb8 by @m0j0hn) |
|
✅ Build vcs build-37.master completed (commit 49ca4bbaa1 by @m0j0hn) |
|
✅ Build vcs build-38.master completed (commit 7a5d5029b5 by @m0j0hn) |
|
✅ Build vcs build-46.master completed (commit c524d90f94 by @m0j0hn) |
|
@shurcooL I think this PR is in final form - can you please take another look at it and let me know +1 or -1 at this time - or if you and team are even open to the idea of "go test" doing nothing by default? |
|
I'm not an owner of this project, I just spotted an issue and wanted to point it out. You'll want to get a review from someone qualified to do it. |
|
Ok, Thank you, @shurcooL! @mattfarina @technosophos Can you please consider this PR? Thanks! |
m0j0hn
changed the title
m0j0hn
changed the title
|
✅ Build vcs build-68.master completed (commit db18ec1c06 by @m0j0hn) |
|
I'm not opposed to this on principle. I've done something similar on database libraries where there were certain drivers (MySQL, sqlite, etc) that had specific tests. But I do feel a little uncomfortable with the idea that a plain |
|
I agree with @technosophos on this one. Imagine the case of a windows developer is working on this package. There is no Can we get this where you can turn off certain tests? |
|
Since I've not heard back on this PR since April (5 month) I'm going to close it. If there is new movement it can be reopened. |
Add Golang build constraints (build tags) to *_test.go, so one can run only the tests for the module being developed, instead of previous default of all.
Note that Makefile and appveyor.yml have been updated to run all tests, as before.
Note that running "git test" now does nothing by default - this is a change.
Syntax: Run all tests:
go test -tags all
Syntax: Run git tests:
go test -tags git