-
Notifications
You must be signed in to change notification settings - Fork 0
Kr/feature/reveal lp variable maps1 #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…that we care about
…positive variables
…transformed into simple expressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new variable mapping output to the ToLPStandardForm1 and ToLPStandardForm2 methods, which provides a mapping from the original variables of an optimization problem to their standard form representation.
Key changes include:
- Modified method signatures to return an additional variable map parameter
- Updated all existing test calls to handle the new return value
- Added comprehensive test cases to verify the variable mapping functionality
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| problem/optimization_problem.go | Modified ToLPStandardForm1, ToLPStandardForm2, and ToProblemWithAllPositiveVariables methods to return variable mappings |
| testing/problem/optimization_problem_test.go | Updated existing test calls and added new test cases for variable mapping verification |
| go.mod | Updated SymbolicMath.go dependency version from v0.2.5 to v0.2.6 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 86.76% 87.43% +0.66%
==========================================
Files 27 35 +8
Lines 3687 4169 +482
==========================================
+ Hits 3199 3645 +446
- Misses 440 470 +30
- Partials 48 54 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Introduces a new output to
ToLPStandardForm1andToLPStandardForm2which maps the original variables of the optimization problem to the standard form version.Notes
Polynomial.Simplifymethod?Resolves #19