Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a flag parameter to allow limiting spyable availability #64

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

dafurman
Copy link
Contributor

See #41 for conversation leading up to this PR

README.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9062fb) 95.98% compared to head (353844a) 96.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   95.98%   96.18%   +0.19%     
==========================================
  Files          15       15              
  Lines         573      603      +30     
==========================================
+ Hits          550      580      +30     
  Misses         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafurman
Copy link
Contributor Author

@Matejkob

From your suggestion here, I covered

Updating the README
Providing detailed documentation, with an example of a custom-defined flag as well as the DEBUG one

I'm happy to do it, but I'm not sure what you meant about refreshing the examples package, as it seems empty anyways to me right now. I'm not too familiar with DocC, in case you could give some direction here.

@dafurman dafurman marked this pull request as ready for review November 12, 2023 19:32
@Matejkob
Copy link
Owner

From your suggestion here, I covered

Updating the README
Providing detailed documentation, with an example of a custom-defined flag as well as the DEBUG one

I'm happy to do it, but I'm not sure what you meant about refreshing the examples package, as it seems empty anyways to me right now. I'm not too familiar with DocC, in case you could give some direction here.

Regarding the Examples package, I was referring to the one located at https://github.com/Matejkob/swift-spyable/tree/main/Examples. This is a separate Swift Package that contains practical examples demonstrating how to use the macro in real-world projects.

It would be great if you could refresh this Examples package by ensuring that it's up-to-date and accurately reflects the current capabilities and usage of our macro.

@dafurman
Copy link
Contributor Author

Unfortunately due to the limitation of not being able to define preprocessor flags on packages, I don't really think there's an effective way to demo this without a full-fledged .xcodeproj. Not sure if it's worth the trouble to restructure the example just for this, when it's also documented, but let me know what you think. This also raises another limitation of this flag - it can't be used within packages.

Copy link
Owner

@Matejkob Matejkob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again thanks a lot for your contribution! 🚀

@Matejkob Matejkob merged commit dcfa49f into Matejkob:main Nov 21, 2023
4 checks passed
@Matejkob Matejkob linked an issue Nov 21, 2023 that may be closed by this pull request
@dafurman dafurman deleted the limitMacroViaFlags branch November 28, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using macro in test only
2 participants