Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ComboBox to fix #120 #127

Merged

Conversation

@l1pton17
Copy link
Contributor

@l1pton17 l1pton17 commented Nov 10, 2015

Fix ComboBox shifting around a pixel while dropdown menu is open.
Also remove a clone of input control in a popup, so we don't need to use comboboxassist.

l1pton17 added 6 commits Oct 28, 2015
F**k with SnapsToDevicePixels and UseLayoutRounding
…ixVirtualizingComboBox

Conflicts:
	MainDemo.Wpf/TextFields.xaml
	MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.ComboBox.xaml
…ixVirtualizingComboBox

Conflicts:
	MainDemo.Wpf/TextFields.xaml
@l1pton17 l1pton17 changed the title Fix ComboBox Change ComboBox to fix #120 Nov 10, 2015
@ButchersBoy
Copy link
Collaborator

@ButchersBoy ButchersBoy commented Nov 10, 2015

Problem is, you get this situation if the popup has to move:

image

Also, underline is 1 pixel higher on combo compared to text box (this is not specific to this PR):

image

@ButchersBoy
Copy link
Collaborator

@ButchersBoy ButchersBoy commented Nov 11, 2015

What are your thoughts on this? Visually, I really like the style for the "cover-up" but it is problematic. I am wondering if:

  • Use "cover-up" for non editable combos only
  • Provide "cover-up" and "traditional" styles so users can use
  • Leave as-is

@l1pton17
Copy link
Contributor Author

@l1pton17 l1pton17 commented Nov 11, 2015

@ButchersBoy i think that i can make both styles in a few days
combobox

@ButchersBoy
Copy link
Collaborator

@ButchersBoy ButchersBoy commented Nov 11, 2015

Your animation looks better. Can I try this before you make two styles? If we can make this work I'd rather a single style than two.

@l1pton17
Copy link
Contributor Author

@l1pton17 l1pton17 commented Nov 11, 2015

@ButchersBoy sorry, i meant, that will be one combobox style which contains a popup with two different templates - above and below an input control.

@ButchersBoy
Copy link
Collaborator

@ButchersBoy ButchersBoy commented Nov 11, 2015

ah OK :-)

@ButchersBoy
Copy link
Collaborator

@ButchersBoy ButchersBoy commented Nov 11, 2015

Just to be a pain :) What about this? I have the combo at the bottom of the screen, straddled across 2 monitors, you can see the popup gets pushed to the side:

image

In this scenario, either the full cover up, or "classic" style is better...

Add popup that changes child template according to position
@l1pton17
Copy link
Contributor Author

@l1pton17 l1pton17 commented Nov 14, 2015

@ButchersBoy now we have above and under input control popup's templates, and also "simple" template if we can't use cover up template (in case of 2 monitors for example).

@ButchersBoy
Copy link
Collaborator

@ButchersBoy ButchersBoy commented Nov 16, 2015

I'll try and have a look this week, and we'll try and get this in for 1.2.

@ButchersBoy ButchersBoy added this to the ver 1.2 milestone Nov 16, 2015
@l1pton17
Copy link
Contributor Author

@l1pton17 l1pton17 commented Nov 17, 2015

Sorry, I forgot to fix underline, will be fixed in a few days

@l1pton17
Copy link
Contributor Author

@l1pton17 l1pton17 commented Nov 17, 2015

Done

@ButchersBoy
Copy link
Collaborator

@ButchersBoy ButchersBoy commented Nov 18, 2015

Firstly; this looks awesome - great work.

Secondly, I want to get this bang on now. I see you've introduced ComboBoxPopup which gives the extra control; so, can we figure out a way of collapsing the wrapper/clip type row, when the popup displays in an odd position (due to the multiple monitor issue)? If we could just collapse this under those circumstances then I think we would have it nailed.

I can look at this but you might want to finish the job yourself? Let me know what you want to do.

@l1pton17
Copy link
Contributor Author

@l1pton17 l1pton17 commented Nov 18, 2015

@ButchersBoy done, if i understand you correctly.

@ButchersBoy
Copy link
Collaborator

@ButchersBoy ButchersBoy commented Nov 18, 2015

Ah sorry...I hadn't pulled latest properly, my bad!

Looks great then 😄 👍

ButchersBoy added a commit that referenced this issue Nov 18, 2015
@ButchersBoy ButchersBoy merged commit e3ab0d4 into MaterialDesignInXAML:master Nov 18, 2015
1 check passed
@l1pton17 l1pton17 deleted the FixVirtualizingComboBox branch Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants