Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filled and Outlined DatePicker styles #1501

Merged
merged 3 commits into from Dec 1, 2019

Conversation

@jizc
Copy link
Contributor

jizc commented Nov 5, 2019

Fixes #1478

FilledAndOutlinedDatePickerStyles

The new DatePickerTextBox style is a modified version of MaterialDesignTextBoxBase. The spacing in the styles are perhaps not exactly like the spec, but it's identical to the new Filled and Outlined TextBox styles in this library. I felt it was better to be consistent with those.

This PR replaces the template in MaterialDesignDatePicker, but I've attempted to make certain that the default style is not changed.

@Keboo Keboo self-requested a review Nov 5, 2019
jizc and others added 2 commits Nov 6, 2019
Inherited attached properties can have performance implications. So instead we simply forward them as needed.
@Keboo Keboo added this to the 3.0.0 milestone Dec 1, 2019
@Keboo Keboo added the enhancement label Dec 1, 2019
@Keboo

This comment has been minimized.

Copy link
Member

Keboo commented Dec 1, 2019

Great work! Thanks for the contribution

@Keboo
Keboo approved these changes Dec 1, 2019
@Keboo Keboo merged commit de5b054 into MaterialDesignInXAML:master Dec 1, 2019
1 check passed
1 check passed
MaterialDesignInXAML.MaterialDesignInXamlToolkit #20191201.13 succeeded
Details
@jizc jizc deleted the jizc:feature/filled-date-picker branch Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.