Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add None value to PackIconKind enum #1633

Merged
merged 2 commits into from Feb 3, 2020

Conversation

@schulz3000
Copy link
Contributor

schulz3000 commented Feb 1, 2020

  • Adjust the script so that the first member is always called "None" (new PackIconKind enum + PackIconDataFactory generated)
  • Ensure the PackIcon control shows nothing and properly handles this new "None" (Tested it with Demo. Looks like no further changes needed to display "nothing" for None)

Fix #1627

Keboo and others added 2 commits Feb 1, 2020
- [x] Adjust the script so that the first member is always called "None" (new PackIconKind enum + PackIconDataFactory generated)
- [x]  Ensure the PackIcon control shows nothing and properly handles this new "None" (Tested it with Demo. Looks like no further changes needed to display "nothing" for None)

Fix #1627
@schulz3000 schulz3000 requested a review from Keboo Feb 1, 2020
@Keboo
Keboo approved these changes Feb 2, 2020
@Keboo Keboo added this to the 3.1.0 milestone Feb 2, 2020
@Keboo Keboo merged commit f3eea0b into MaterialDesignInXAML:master Feb 3, 2020
1 check passed
1 check passed
MaterialDesignInXAML.MaterialDesignInXamlToolkit Build #20200202.2 succeeded
Details
@schulz3000 schulz3000 deleted the schulz3000:IconThingNone branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.