Tabs And NavigationRail Styles for WPF TabControl

[HClausing]

Tabs:

Navigation Rail:

Source:
Tabs
NavigationRail

[seasonyuu]

It's pretty nice !

[Keboo]

This is really great work! Thank you for doing this!

A few comments:

• It would be great to pull the generic TabControl styles out for now, and submit a follow up PR. TabControl styles are a bit of a hot button topic, and I need to get more approval before that portion merges.

Some other optional items that could also be done later:

• Making the Divider optional. It looks like we are using a drop shadow for it now, but the spec appears to just be a simple line.
• Include in demo app, a sample using text labels. Ideally this show default with text wrapping. It might be nice to also have the demo show the text label only appearing on the selected tab (Selected text labels example).
• Demo app sample showing badge control use in the TabItem Header.
• Demo app showing it used for bottom navigation

[HClausing]

This is really great work! Thank you for doing this!

A few comments:

• It would be great to pull the generic TabControl styles out for now, and submit a follow up PR. TabControl styles are a bit of a hot button topic, and I need to get more approval before that portion merges.

Some other optional items that could also be done later:

• Making the Divider optional. It looks like we are using a drop shadow for it now, but the spec appears to just be a simple line.
• Include in demo app, a sample using text labels. Ideally this show default with text wrapping. It might be nice to also have the demo show the text label only appearing on the selected tab (Selected text labels example).
• Demo app sample showing badge control use in the TabItem Header.
• Demo app showing it used for bottom navigation

Thanks for the review!

Related to the Divider tip, I've added it. About the drop shadow, I made it inheritable by materialDesign:ShadowAssist.ShadowDepth, with a Depth2 as (old) default. Now is set to Depth0):

[Keboo]

This is looking really nice and I would like to include it in the 3.x release.

A few things that are needed for this to merge:

• It appears that the background/foreground of the items does not follow inherited theme brushes. I would expect the foreground/background to track with whatever was set on the parent window.
  
• There appears to be a rendering issue with the shadows/separator.
  
• The non-rail styles should get pulled out. For the initial release it should only be the navigation rail bits.

[HClausing]

This is looking really nice and I would like to include it in the 3.x release.

A few things that are needed for this to merge:

• It appears that the background/foreground of the items does not follow inherited theme brushes. I would expect the foreground/background to track with whatever was set on the parent window.
  
• There appears to be a rendering issue with the shadows/separator.
  
• The non-rail styles should get pulled out. For the initial release it should only be the navigation rail bits.

Thanks for the review! We are getting close to finish!

⚠" It appears that the background/foreground of the items does not follow inherited theme brushes. I would expect the foreground/background to track with whatever was set on the parent window."
Background Fixed. Now I'm fighting (without success) with Foreground / TextElement.Foreground. It doesn't inherit the brush over VisualTree. Default TabControl defines the Background property to White, so, the Background={x:Null} removed from last review comes back.

⚠"There appears to be a rendering issue with the shadows/separator."
Should I remove the shadow? Or just on sample app? (by default it's Depth 0). Ocurred just on dark theme.

✅" The non-rail styles should get pulled out. For the initial release it should only be the navigation rail bits."
If you don't mind, I'll keep the XAML styles commented for a future implementation.

[Keboo]

I push some changes that should address the colors (I also added a simple UI test for it).

Regarding the shadow I would suggest that we simply remove it for now. The spec only appears to have the separator so I think it is fine to start small.

I am fine if you simply want to comment out the other tab styles.

[HClausing]

I push some changes that should address the colors (I also added a simple UI test for it).

Regarding the shadow I would suggest that we simply remove it for now. The spec only appears to have the separator so I think it is fine to start small.

I am fine if you simply want to comment out the other tab styles.

Hello @Keboo !

I've seen that you removed this Line from Style:
Setter Property="Background" Value="{x:Null}"

Didn't you have any problems on your tests without this? For me, without this, the default TabControl's Style applies a white solid brush. This is the reason why I insisted setting it to null.

[HClausing]

Next stage of study/work/test:

• Add a NavigationRailAssit with those attached properties:

• TextTabMode : Persistent / OnSelect;

• TextTab : Some short text for each TabItem;

• BadgeContent : For dynamic TabItem information.

• Work on NavigationRail template to use new Attached Properties.

[Keboo]

@HClausing I got this merged for the 3.2.0 release. I do have a copy of the work prior to tonight's changes sitting in one of my branches as well.

[HClausing]

Hello!

Thanks so much. One doubt: To use the NavigationRail style, it wont' be on Defautls.xaml (like Textbox, etc) and needs to be referenced on merged dictionaries of app.xaml (like DataGrid, PopupBox, etc) ?

[HClausing]

Another thing: The Navigation Rail page on DemoApp appears to be outdated (using de old version with shadows):

Last change :