Proposal: add CornerRadius properties to the DrawerHost #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added four DependencyProperties, one for each Drawer, to control the CornerRadi
|
I think the CornerRadius is the right call here. Nice addition! |
Keboo
added
enhancement
release notes
Keboo
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2332
Result:
It just adds four properties for the CornerRadius of each Drawer. To make it appear like in the Spec and pictures you'll need to specify each corner radius in the property, like this:
<materialDesign:DrawerHost LeftDrawerCornerRadius="0 20 20 0" BottomDrawerCornerRadius="25 25 0 0">Maybe it could be improved to accept only one number and automatically figure out which two corners to smooth, although that would remove some customization. Not sure what's the right way