Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include regex verbatim in SHOW CREATE SOURCE #1762

Closed
sploiselle opened this issue Jan 30, 2020 · 4 comments · Fixed by #2047
Closed

Include regex verbatim in SHOW CREATE SOURCE #1762

sploiselle opened this issue Jan 30, 2020 · 4 comments · Fixed by #2047
Assignees
Labels
C-bug Category: something is broken
Milestone

Comments

@sploiselle
Copy link
Contributor

After creating a dynamic file source, and structuring it with regex, SHOW CREATE SOURCE does not provide specific enough data to let the user re-create the source.

One of the impossible-to-retrieve components here is the regular expression included in CREATE SOURCE ... WITH (regex='...', ...). We should include at least that detail in SHOW CREATE SOURCE so users can recreate their sources if need be.

@umanwizard Are you a good candidate for this work?

@sploiselle sploiselle added the C-feature Category: new feature or request label Jan 30, 2020
@umanwizard umanwizard self-assigned this Jan 30, 2020
@umanwizard
Copy link
Contributor

Yes, this is a known issue (well, known to me in my head, not necessarily known in the issue tracker -- sorry!) It will change with the new CREATE SOURCE syntax anyway, but I'll keep this open just in case

@rjnn rjnn added this to the 0.2 milestone Feb 18, 2020
@rjnn
Copy link
Contributor

rjnn commented Feb 18, 2020

@umanwizard was this fixed when the new CREATE SOURCE syntax shipped in 0.10?

@benesch
Copy link
Member

benesch commented Feb 18, 2020

No, if anything the situation is worse, because SHOW CREATE SOURCE shows an old-style URL.

@umanwizard umanwizard added C-bug Category: something is broken and removed C-feature Category: new feature or request labels Feb 18, 2020
@umanwizard
Copy link
Contributor

I consider this a bug; changing the labels appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants