Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type errors in joins with `using`. #2388

Closed
frankmcsherry opened this issue Mar 23, 2020 · 1 comment
Closed

Type errors in joins with `using`. #2388

frankmcsherry opened this issue Mar 23, 2020 · 1 comment
Labels

Comments

@frankmcsherry
Copy link
Member

@frankmcsherry frankmcsherry commented Mar 23, 2020

Due to recent verification of type information, test/slt/cockroach/join.slt has a test that panics, which is reduced down to

    CREATE TABLE onecolumn (x INT)
    CREATE TABLE othertype (x TEXT)
    SELECT * FROM (onecolumn AS a JOIN othertype AS b USING(x))

The two column types are not the same. Perhaps they could be, and I'm not myself certain what they should be converted to (or errored about). Per @benesch the only reason this hasn't been a problem before is that in the test there is no data.

cc @jamii

@frankmcsherry frankmcsherry added the C-bug label Mar 23, 2020
@benesch benesch closed this Mar 23, 2020
@benesch benesch reopened this Mar 23, 2020
@frankmcsherry frankmcsherry added the A-sql label Mar 23, 2020
@benesch

This comment has been minimized.

Copy link
Member

@benesch benesch commented Mar 23, 2020

Oops, accidental close.

The SLT test expects that query to error with a message like text/int columns cannot be matched. We are discovering that fact, but via a panic, and we should instead surface it as a proper plan time error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.