storage: make ReclockFollower shareable #14558
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of BIR, the source reader operator will need access to the reclock trace to "invert" a resumption_frontier into a upstream commit frontier. This pr makes the
ReclockFollower
share-able, within a single thread (worker), by usingRc<RefCell>
. This should have a relatively low cost. This pr does NOT implement the inversion logic.Notes:
RefCell
for_each
. @petrosagg came up with a way to avoid this withYoke
, but that seems needlessly complex for our usecae.borrow_mut()
users keep their&mut
signatures. This can ensure that we reduce the chance of writing code that will hit a borrow error, while keep the api clean (ReclockFollower: Clone
)Motivation
part of BIR
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protobuf
label.