Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the application of simplification #2204

Merged

Conversation

@frankmcsherry
Copy link
Member

frankmcsherry commented Mar 4, 2020

This PR restricts the application of the simplification transformation (which unpacks equality predicates on complex expressions, so that they can be used as join keys). It now ensures that it is only applied when each of the two expressions in an equality depend on exactly one input collection and the two are not the same input collection (otherwise, the constraint can, and probably should, but pushed down into that collection).

Changes are much smaller with whitespace ignored. Lots of code got one additional indentation level.

fixes #761

@frankmcsherry frankmcsherry requested a review from wangandi Mar 4, 2020
@frankmcsherry

This comment has been minimized.

Copy link
Member Author

frankmcsherry commented Mar 4, 2020

Coincidentally, the doctest was actually a case where we wanted to avoid the simplification!

@frankmcsherry frankmcsherry self-assigned this Mar 4, 2020
@frankmcsherry frankmcsherry merged commit a54e7cb into MaterializeInc:master Mar 4, 2020
14 checks passed
14 checks passed
buildkite/tests Build #5702 passed (23 minutes, 33 seconds)
Details
buildkite/tests/bath-lint-and-rustfmt Passed (21 seconds)
Details
buildkite/tests/bulb-bulb-full-sql-logic-tests Passed (0 seconds)
Details
buildkite/tests/bulb-short-sql-logic-tests Passed (2 minutes, 15 seconds)
Details
buildkite/tests/cargo-test Passed (1 minute, 2 seconds)
Details
buildkite/tests/docker-build Passed (10 minutes, 40 seconds)
Details
buildkite/tests/face-with-monocle-miri-test Passed (3 minutes, 23 seconds)
Details
buildkite/tests/metabase-demo Passed (2 minutes, 9 seconds)
Details
buildkite/tests/paperclip-clippy-and-doctests Passed (1 minute, 18 seconds)
Details
buildkite/tests/pipeline Passed (15 seconds)
Details
buildkite/tests/racing-car-testdrive Passed (3 minutes, 14 seconds)
Details
buildkite/tests/shower-streaming-demo Passed (1 minute, 37 seconds)
Details
license/cla Contributor License Agreement is signed.
Details
netlify/materializeinc/deploy-preview Deploy preview canceled.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.