Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check types are comparable in USING #2403

Merged
merged 3 commits into from Mar 25, 2020
Merged

Conversation

@jamii
Copy link
Member

jamii commented Mar 24, 2020

Fixes #2388

@jamii jamii requested a review from frankmcsherry Mar 24, 2020
Copy link
Member

frankmcsherry left a comment

This all looks very sensible, thanks! We should do a full SLT to see if it cleans things up! :D

src/sql/query.rs Outdated Show resolved Hide resolved
@jamii jamii force-pushed the jamii:fix-using-crash branch from 4662d3c to 8b5835c Mar 25, 2020
@jamii

This comment has been minimized.

Copy link
Member Author

jamii commented Mar 25, 2020

CI is flaking out at the moment. Will merge and do full slt later today.

@jamii jamii merged commit 61d6289 into MaterializeInc:master Mar 25, 2020
16 checks passed
16 checks passed
buildkite/tests Build #6139 passed (21 minutes, 30 seconds)
Details
buildkite/tests/bath-lint-and-rustfmt Passed (36 seconds)
Details
buildkite/tests/book-catalog-compatibility-check Passed (41 seconds)
Details
buildkite/tests/bulb-bulb-full-sql-logic-tests Passed (0 seconds)
Details
buildkite/tests/bulb-short-sql-logic-tests Passed (1 minute, 51 seconds)
Details
buildkite/tests/cargo-test Passed (1 minute, 12 seconds)
Details
buildkite/tests/chbench-sanity-check Passed (2 minutes, 9 seconds)
Details
buildkite/tests/docker-build Passed (15 minutes, 33 seconds)
Details
buildkite/tests/face-with-monocle-miri-test Passed (57 seconds)
Details
buildkite/tests/metabase-demo Passed (1 minute, 11 seconds)
Details
buildkite/tests/paperclip-clippy-and-doctests Passed (1 minute, 18 seconds)
Details
buildkite/tests/pipeline Passed (20 seconds)
Details
buildkite/tests/racing-car-testdrive Passed (4 minutes, 14 seconds)
Details
buildkite/tests/shower-streaming-demo Passed (44 seconds)
Details
license/cla Contributor License Agreement is signed.
Details
netlify/materializeinc/deploy-preview Deploy preview canceled.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.