Don't reuse a RowArena for MapFilterProject #4578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MaterializeInc#4463 we introduced MapFilterProjects on top of Gets to reduce the amount of data that we had to pack and unpack across operator boundaries. When doing this, I made one RowArena that was used across each invocation of MFP, which resulted in memory buildup over time. This change changes this to occur per-row so that we can throw away intermediate data.
frankmcsherry
approved these changes
Oct 21, 2020
wangandi
approved these changes
Oct 21, 2020
|
Andi did the hard work by bisecting to find the problematic commit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4463 we introduced MapFilterProjects on top of Gets to reduce the
amount of data that we had to pack and unpack across operator
boundaries. When doing this, I made one RowArena that was used across
each invocation of MFP, which resulted in memory buildup over time. This
change changes this to occur per-row so that we can throw away
intermediate data.
This change is