A second pass at redoing load_builtin.py #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Second pass at making it possible to load a single module inside mathics.builtin rather than all modules at once. loop to updating ``display_operators_set`` is now done inside module import rather than its own independent loop. ``add_builtins_from_builtin_module()`` isolated from inside ``add_builtins_from_builtin_modules()` so that we can eventually remove the latter. More type annotations, docstrings and comments.
rocky
force-pushed
the
module_load_refactor-part2
branch
from
25719e7
to
86bfa5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second pass at making it possible to load a single module inside
mathics.builtirather than all modules at once.display_operators_setis now done inside module import rather than its own independent loop.add_builtins_from_builtin_module()isolated from insideadd_builtins_from_builtin_modules()so that we can eventually remove the latter.