From 6061a243e4971e5750cc6aa23b2860f3d0ee74cb Mon Sep 17 00:00:00 2001
From: Tim Macfarlane <timmacfarlane@gmail.com>
Date: Fri, 5 May 2017 09:54:53 +0200
Subject: [PATCH] throw better exception when duplicate keys are found

---
 test/keys.js      | 11 +++++++++++
 test/main.js      |  7 +++++++
 vnode/selector.js |  5 +++++
 vtree/diff.js     |  7 ++++++-
 4 files changed, 29 insertions(+), 1 deletion(-)
 create mode 100644 vnode/selector.js

diff --git a/test/keys.js b/test/keys.js
index 0790603e..dc706649 100644
--- a/test/keys.js
+++ b/test/keys.js
@@ -655,6 +655,17 @@ test('mixed keys move from i>0 to i<length-1', function (assert) {
     assert.end()
 })
 
+test('duplicate keys throws appropriate error', function (assert) {
+    var start = nodesFromArray(['1', '2', '3'])
+    var end = nodesFromArray(['1', '2', '2', '3'])
+
+    assert.throws(function () {
+      diff(start, end)
+    }, 'duplicate vdom key')
+
+    assert.end()
+})
+
 /*
 keyTest(
     [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42],
diff --git a/test/main.js b/test/main.js
index 547504e2..ba7440ce 100644
--- a/test/main.js
+++ b/test/main.js
@@ -9,6 +9,7 @@ var TextNode = require("../vnode/vtext")
 var version = require("../vnode/version")
 var assertEqualDom = require("./lib/assert-equal-dom.js")
 var patchCount = require("./lib/patch-count.js")
+var selector = require("../vnode/selector")
 
 
 
@@ -1027,6 +1028,12 @@ test("Different namespaces creates a patch", function (assert) {
     assert.end()
 })
 
+test('can pretty print node as selector', function (assert) {
+    var node = h("div", {id: 'an-id', className: " class-1  class-2"})
+    assert.equal(selector(node), "div#an-id.class-1.class-2")
+    assert.end()
+})
+
 // Safely translates style values using the DOM in the browser
 function style(name, value) {
     var node = render(h())
diff --git a/vnode/selector.js b/vnode/selector.js
new file mode 100644
index 00000000..a6bc5a41
--- /dev/null
+++ b/vnode/selector.js
@@ -0,0 +1,5 @@
+module.exports = function selector (node) {
+  return node.tagName.toLowerCase()
+    + (node.properties.id ? '#' + node.properties.id : '')
+    + (node.properties.className ? '.' + node.properties.className.trim().replace(/ +/g, '.') : '')
+}
diff --git a/vtree/diff.js b/vtree/diff.js
index b5bccbd0..e62b632a 100644
--- a/vtree/diff.js
+++ b/vtree/diff.js
@@ -6,6 +6,7 @@ var isVText = require("../vnode/is-vtext")
 var isWidget = require("../vnode/is-widget")
 var isThunk = require("../vnode/is-thunk")
 var handleThunk = require("../vnode/handle-thunk")
+var selector = require("../vnode/selector")
 
 var diffProps = require("./diff-props")
 
@@ -400,7 +401,11 @@ function keyIndex(children) {
         var child = children[i]
 
         if (child.key) {
-            keys[child.key] = i
+            if (keys[child.key]) {
+                throw new Error('duplicate vdom key: ' + child.key + ', vdom: ' + selector(child))
+            } else {
+                keys[child.key] = i
+            }
         } else {
             free.push(i)
         }