Matt Esch Matt-Esch

Organizations

@eschltd
@Matt-Esch
Complete call request parser
@Matt-Esch
@Matt-Esch
Matt-Esch commented on pull request Raynos/tchannel-gen#1
@Matt-Esch

I'd rather you deleted this and put var NODE_ENV = require('process').env.NODE_ENV; at the top.

Matt-Esch commented on pull request Raynos/tchannel-gen#1
@Matt-Esch

I don't think you should wait until this point to set the process title. You want to do it as one of the first things as process monitoring often d…

Matt-Esch commented on pull request Raynos/tchannel-gen#1
@Matt-Esch

Poorly named. This is onClientsReady or onDepsReady. Consider moving the closure outside, and passing (err, opts) to it with a smaller closure.

Matt-Esch commented on pull request Raynos/tchannel-gen#1
@Matt-Esch

seems to be missing an opinion about npm/shrinkwrap

Matt-Esch commented on pull request Raynos/tchannel-gen#1
@Matt-Esch

I am working on a project with a monster number of clients. I will be decomposing it into a dependency graph by exporting each client with a list o…

Matt-Esch commented on pull request Raynos/tchannel-gen#1
@Matt-Esch

Do you really suggest putting methods on Application in a production service? I think it's bad to encourage people to use functions like objects fo…

Matt-Esch commented on pull request Raynos/tchannel-gen#1
@Matt-Esch

You want to update this to prune the deps I removed from logtron

Matt-Esch commented on pull request Raynos/tchannel-gen#1
@Matt-Esch

:+1:

Matt-Esch commented on pull request Raynos/tchannel-gen#1
@Matt-Esch

We should really just make this the standard, I have to put this in every project I touch and it's a necessity to write efficient code.

Matt-Esch opened pull request uber/tchannel#800
@Matt-Esch
optimization suggestions
1 commit with 10 additions and 0 deletions
@Matt-Esch
Matt-Esch created tag v8.4.0 at uber/logtron
Matt-Esch deleted branch update-deps at uber/logtron
Matt-Esch deleted branch expose-base-meta at uber/logtron
@Matt-Esch
Matt-Esch merged pull request uber/logtron#29
@Matt-Esch
Expose base meta so it can be updated
1 commit with 1 addition and 1 deletion
@Matt-Esch
Matt-Esch merged pull request uber/logtron#28
@Matt-Esch
Update deps
3 commits with 4 additions and 4 deletions
@Matt-Esch
  • 85b6b1e
    update sentry logger to v3.0.3
Matt-Esch commented on issue uber/sentry-logger#6
@Matt-Esch

//cc @Raynos

Matt-Esch opened pull request uber/logtron#28
@Matt-Esch
Update deps
2 commits with 3 additions and 3 deletions
Matt-Esch created branch update-deps at uber/logtron
@Matt-Esch
logger published version