Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of uDMX connection options #24

Merged
merged 2 commits into from Jul 5, 2019

Conversation

Projects
None yet
1 participant
@MattIPv4
Copy link
Owner

commented Jul 5, 2019

  • Allows the setting of the uDMX vendor id through the udmx_vendor_id keyword argument when creating the controller.
  • Allows setting of product id for uDMX with keyword argument udmx_product_id when creating the uDMX controller.
  • Allow the uDMX USB bus to be defined by specifying the keyword argument udmx_bus during controller creation.
  • Allows the setting of the uDMX USB address by providing a value with the udmx_address keyword argument during controller instantiation.
  • Breaking Change: makes the udmx instance private within the controller to mitigate the possibility of someone breaking it.

@MattIPv4 MattIPv4 self-assigned this Jul 5, 2019

@MattIPv4 MattIPv4 merged commit b4d45fd into master Jul 5, 2019

3 of 4 checks passed

Scrutinizer Analysis: Errored – Tests: passed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
WIP Ready for review
Details
codebeat no reportable quality changes
Details

@MattIPv4 MattIPv4 deleted the udmx-options branch Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.